From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60850)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <keir.xen@gmail.com>) id 1T4XQY-0006ER-Vx
	for qemu-devel@nongnu.org; Thu, 23 Aug 2012 09:26:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <keir.xen@gmail.com>) id 1T4XQT-0001Np-6a
	for qemu-devel@nongnu.org; Thu, 23 Aug 2012 09:26:26 -0400
Received: from mail-gg0-f173.google.com ([209.85.161.173]:55783)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <keir.xen@gmail.com>) id 1T4XQT-0001Nb-1h
	for qemu-devel@nongnu.org; Thu, 23 Aug 2012 09:26:21 -0400
Received: by ggna5 with SMTP id a5so163960ggn.4
	for <qemu-devel@nongnu.org>; Thu, 23 Aug 2012 06:26:19 -0700 (PDT)
Date: Thu, 23 Aug 2012 14:26:09 +0100
From: Keir Fraser <keir.xen@gmail.com>
Message-ID: <CC5BEE01.3CBD1%keir.xen@gmail.com>
In-Reply-To: <1345727912.12501.83.camel@zakaz.uk.xensource.com>
Mime-version: 1.0
Content-type: text/plain;
	charset="US-ASCII"
Content-transfer-encoding: 7bit
Subject: Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 01/17] hvm: Modify
 interface to support multiple ioreq server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Campbell <Ian.Campbell@citrix.com>, Julien Grall <julien.grall@citrix.com>
Cc: "christian.limpach@gmail.com" <christian.limpach@gmail.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>

On 23/08/2012 14:18, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:

>> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h
>> index 4022a1d..87aacd3 100644
>> --- a/xen/include/public/hvm/ioreq.h
>> +++ b/xen/include/public/hvm/ioreq.h
>> @@ -34,6 +34,7 @@
>>  
>>  #define IOREQ_TYPE_PIO          0 /* pio */
>>  #define IOREQ_TYPE_COPY         1 /* mmio ops */
>> +#define IOREQ_TYPE_PCI_CONFIG   2 /* pci config space ops */
>>  #define IOREQ_TYPE_TIMEOFFSET   7
>>  #define IOREQ_TYPE_INVALIDATE   8 /* mapcache */
> 
> I wonder why we skip 2-6 now -- perhaps they used to be something else
> and we are avoiding them to avoid strange errors? In which case adding
> the new on as 9 might be a good idea.

They were almost certainly used for representing R-M-W ALU operations back
in the days of the old IO emulator, very long ago. Still, there's no harm in
leaving them unused.

 -- Keir