From: Alexander Graf <agraf@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Don't skip stracing for fcntl64 failure case
Date: Tue, 6 Dec 2011 00:34:52 +0100 [thread overview]
Message-ID: <CC613A47-963C-4B7E-9C6C-F7195469AE3A@suse.de> (raw)
In-Reply-To: <1323126710-2242-1-git-send-email-peter.maydell@linaro.org>
On 06.12.2011, at 00:11, Peter Maydell wrote:
> In an fcntl64 failure path, we were returning directly rather than
> simply breaking out of the switch statement. This skips the strace
> code for printing the syscall return value, so don't do that.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Alexander Graf <agraf@suse.de>
Alex
> ---
> Alex Graf spotted this one...
>
> linux-user/syscall.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index f227097..4846b41 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -7521,8 +7521,10 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> #endif
>
> cmd = target_to_host_fcntl_cmd(arg2);
> - if (cmd == -TARGET_EINVAL)
> - return cmd;
> + if (cmd == -TARGET_EINVAL) {
> + ret = cmd;
> + break;
> + }
>
> switch(arg2) {
> case TARGET_F_GETLK64:
> --
> 1.7.5.4
>
next prev parent reply other threads:[~2011-12-05 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 23:11 [Qemu-devel] [PATCH] linux-user/syscall.c: Don't skip stracing for fcntl64 failure case Peter Maydell
2011-12-05 23:34 ` Alexander Graf [this message]
2011-12-06 10:45 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC613A47-963C-4B7E-9C6C-F7195469AE3A@suse.de \
--to=agraf@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).