From: Alexander Graf <agraf@suse.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel List <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging
Date: Tue, 24 Aug 2010 00:54:33 +0200 [thread overview]
Message-ID: <CCBA2EE2-70EC-451F-9A64-EAE5D579DF3C@suse.de> (raw)
In-Reply-To: <4C72FB2C.9000404@codemonkey.ws>
On 24.08.2010, at 00:50, Anthony Liguori wrote:
> On 08/23/2010 05:45 PM, Alexander Graf wrote:
>>> Device_add already works with this set and only required minor changes the s390 specific code. So that part was pretty slick :). The part that didn't work was the drive_add one.
>>>
>>> What is blockdev_add supposed to be? drive_add without IF_SCSI?
>
> drive_add without if= and without the PCI-isms.
>
>>> To be a bit more precise on how things work with this set:
>>>
>>> (qemu) drive_add 0 id=my_disk,if=none,file=/dev/null
>>> OK
>>>
>
> In theory, something like:
>
> (qemu) blockdev_add id=my_disk,file=/dev/null
So why add yet another command when we could use the existing drive_add? Wouldn't it make more sense to deprecate if=!none, move forward from there, make if=none the default and around 0.16 or so drop if= from drive_add?
Alex
next prev parent reply other threads:[~2010-08-23 22:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 22:02 [Qemu-devel] [PATCH 0/5] Add S390 hotplug add support Alexander Graf
2010-08-23 22:02 ` [Qemu-devel] [PATCH 1/5] [S390] Add hotplug support Alexander Graf
2010-08-23 22:02 ` [Qemu-devel] [PATCH 2/5] [S390] Increase amount of virtio pages Alexander Graf
2010-08-23 22:02 ` [Qemu-devel] [PATCH 3/5] Compile device-hotplug on all targets Alexander Graf
2010-08-23 22:02 ` [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging Alexander Graf
2010-08-23 22:21 ` Anthony Liguori
2010-08-23 22:23 ` Alexander Graf
2010-08-23 22:45 ` Alexander Graf
2010-08-23 22:50 ` Anthony Liguori
2010-08-23 22:54 ` Alexander Graf [this message]
2010-08-24 9:31 ` Daniel P. Berrange
2010-08-24 10:45 ` Alexander Graf
2010-08-24 10:51 ` Daniel P. Berrange
2010-08-24 13:40 ` Alexander Graf
2010-08-24 13:44 ` Daniel P. Berrange
2010-08-24 13:46 ` Alexander Graf
2010-08-24 13:51 ` Daniel P. Berrange
2010-08-27 9:27 ` Markus Armbruster
2010-08-24 18:35 ` Anthony Liguori
2010-08-24 21:53 ` Alexander Graf
2010-08-27 9:53 ` Markus Armbruster
2010-08-27 9:56 ` Alexander Graf
2010-08-23 22:02 ` [Qemu-devel] [PATCH 5/5] Expose drive_add on all architectures Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCBA2EE2-70EC-451F-9A64-EAE5D579DF3C@suse.de \
--to=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).