From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWreE-0006eF-Qy for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:13:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWreB-0008Kd-S9 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:13:54 -0400 Received: from usindpps03.hds.com ([207.126.252.16]:56409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWreB-0008Jr-0z for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:13:51 -0400 From: Tomoki Sekiyama Date: Mon, 29 Apr 2013 17:13:37 +0000 Message-ID: In-Reply-To: Content-Language: en-US Content-Type: multipart/mixed; boundary="_002_CDA41AD4179BTomokiSekiyamahdscom_" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH v2 00/11] qemu-ga: fsfreeze on Windows using VSS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Libaiqing , "qemu-devel@nongnu.org" Cc: "mdroth@linux.vnet.ibm.com" , "pbonzini@redhat.com" , "vrozenfe@redhat.com" , Haofeng , "lcapitulino@redhat.com" --_002_CDA41AD4179BTomokiSekiyamahdscom_ Content-Type: text/plain; charset="us-ascii" Content-ID: <82DF9D1284988441AFD2F8387F91BAA7@hds.com> Content-Transfer-Encoding: quoted-printable Hi, On 4/23/13 12:44 , "Tomoki Sekiyama" wrote: >> 2 executing the command "{"execute":"guest-fsfreeze-freeze"}" >>failed,the output is: > >> {"execute":"guest-fsfreeze-freeze"} >> {"error": {"class": "GenericError", "desc": "Failed to >>pVssbc->SetContext. (Error: 8004231b) "}} >>=20 >> Could you give me some advise to debug this problem ? I can provide more >>information if need. > >Is there any logs corresponding to the error in Event Viewer? > >And this might be caused by unsupported VSS_VOLSNAP_ATTR_* flags in >SetContext() >called from qga_vss_fsfreeze_freeze() at qga/vss-win32-requester.cpp, >but I couldn't find out flags not supported on Windows 7 from VSS >references. I'm investigating this issue. Some versions of Windows seem to ignore VSS_VOLSNAP_ATTR_NO_AUTORECOVERY, and to cause an error with VSS_VOLSNAP_ATTR_TRANSPORTABLE. In such cases, we cannot disable Auto-recovery that requires writable snapshots we don't yet support. Because of this, even if we remove TRANSPORTABLE flag, auto-recovery would be enabled and cause another error (VSS_E_OBJECT_NOT_FOUND) on thaw. The patch attached (to be applied after v2 patch) removes TRANSPORTABLE flag, and ignores the VSS_E_OBJECT_NOT_FOUND error on thaw. I think this should resolve the issue in Windows 7, and also works in the other versions of Windows. Could you try this? If it works, I will merge this into my path set and resend it as v3. Thanks, Tomoki Sekiyama --_002_CDA41AD4179BTomokiSekiyamahdscom_ Content-Type: application/octet-stream; name="ignore-notfound.patch" Content-Description: ignore-notfound.patch Content-Disposition: attachment; filename="ignore-notfound.patch"; size=1987; creation-date="Mon, 29 Apr 2013 17:13:37 GMT"; modification-date="Mon, 29 Apr 2013 17:13:37 GMT" Content-ID: <2B6DCE108289174CAB6CC2772F3D00AE@hds.com> Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3FnYS92c3Mtd2luMzItcmVxdWVzdGVyLmNwcCBiL3FnYS92c3Mtd2luMzIt cmVxdWVzdGVyLmNwcAppbmRleCA5MGZmMDI2Li4wZTAyODE4IDEwMDY0NAotLS0gYS9xZ2EvdnNz LXdpbjMyLXJlcXVlc3Rlci5jcHAKKysrIGIvcWdhL3Zzcy13aW4zMi1yZXF1ZXN0ZXIuY3BwCkBA IC0yNTksMTIgKzI1OSwxMSBAQCB2b2lkIHFnYV92c3NfZnNmcmVlemVfZnJlZXplKGludCAqbnVt X3ZvbHMsIEVycm9yICoqZXJyKQogICAgIC8qCiAgICAgICogQ3VycmVudGx5IHdyaXRhYmxlIHNu YXBzaG90cyBhcmUgbm90IHN1cHBvcnRlZC4KICAgICAgKiBUbyBwcmV2ZW50IHRoZSBmaW5hbCBj b21taXQgKHdoaWNoIHJlcXVpcmVzIHRvIHdyaXRlIHRvIHNuYXBzaG90cyksCi0gICAgICogVlNT X1ZPTFNOQVBfQVRUUl9OT19BVVRPUkVDT1ZFUlkgKGZvciBXaW4yMDA4IFNQMiBvciBsYXRlcikg YW5kCi0gICAgICogVlNTX1ZPTFNOQVBfQVRUUl9UUkFOU1BPUlRBQkxFIChmb3IgZWFsaWVyIHZl cnNpb25zKSBhcmUgc3BlY2lmaWVkIGhlcmUuCisgICAgICogVlNTX1ZPTFNOQVBfQVRUUl9OT19B VVRPUkVDT1ZFUlkgKGZvciBXaW4yMDA4IFNQMiBvciBsYXRlcikgCisgICAgICogYXJlIHNwZWNp ZmllZCBoZXJlLgogICAgICAqLwogICAgIGNoayggcFZzc2JjLT5TZXRDb250ZXh0KFZTU19DVFhf QVBQX1JPTExCQUNLIHwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBWU1NfVk9MU05BUF9B VFRSX05PX0FVVE9SRUNPVkVSWSB8Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgVlNTX1ZP TFNOQVBfQVRUUl9UUkFOU1BPUlRBQkxFIHwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBW U1NfVk9MU05BUF9BVFRSX1RYRl9SRUNPVkVSWSkgKTsKIAogICAgIGNoayggcFZzc2JjLT5HYXRo ZXJXcml0ZXJNZXRhZGF0YSgmcEFzeW5jKSApOwpAQCAtMzcyLDcgKzM3MSwxOSBAQCB2b2lkIHFn YV92c3NfZnNmcmVlemVfdGhhdyhpbnQgKm51bV92b2xzLCBFcnJvciAqKmVycikKICAgICBhc3Nl cnQocFZzc2JjKTsKICAgICBhc3NlcnQocEFzeW5jU25hcHNob3QpOwogCi0gICAgX2NoayggV2Fp dEZvckFzeW5jKHBBc3luY1NuYXBzaG90KSwgIkRvU25hcHNob3RTZXQiLCBlcnIsIG91dCApOwor ICAgIEhSRVNVTFQgaHIgPSBXYWl0Rm9yQXN5bmMocEFzeW5jU25hcHNob3QpOworICAgIGlmICho ciA9PSBWU1NfRV9PQkpFQ1RfTk9UX0ZPVU5EKSB7CisgICAgICAgIC8qCisgICAgICAgICAqIE9u IFdpbmRvd3MgZWFybGllciB0aGFuIDIwMDggU1AyIHdoaWNoIGRvZXMgbm90IHN1cHBvcnQKKyAg ICAgICAgICogVlNTX1ZPTFNOQVBfQVRUUl9OT19BVVRPUkVDT1ZFUlkgY29udGV4dCwgZmluYWwg Y29tbWl0IGlzIG5vdAorICAgICAgICAgKiBza2lwcGVkIGFuZCBWU1MgaXMgYWJvcnRlZC4gSW4g dGhpcyBjYXNlLCB3ZSBnZXQgaGVyZS4gU3RpbGwgdGhlCisgICAgICAgICAqIHNuYXBzaG90IGlz IHRha2VuIHN1Y2Nlc3NmdWxseSwgc28gd2UganVzdCBpZ25vcmUgdGhlIGVycm9yLgorICAgICAg ICAgKi8KKyAgICAgICAgcEFzeW5jU25hcHNob3QtPlJlbGVhc2UoKTsKKyAgICAgICAgcEFzeW5j U25hcHNob3QgPSBOVUxMOworICAgICAgICBnb3RvIGZpbmFsOworICAgIH0KKyAgICBfY2hrKCBo ciwgIkRvU25hcHNob3RTZXQiLCBlcnIsIG91dCApOwogICAgIHBBc3luY1NuYXBzaG90LT5SZWxl YXNlKCk7CiAgICAgcEFzeW5jU25hcHNob3QgPSBOVUxMOwogCkBAIC0zODAsNiArMzkxLDcgQEAg dm9pZCBxZ2FfdnNzX2ZzZnJlZXplX3RoYXcoaW50ICpudW1fdm9scywgRXJyb3IgKiplcnIpCiAg ICAgX2NoayggV2FpdEZvckFzeW5jKHBBc3luYyksICJCYWNrdXBDb21wbGV0ZSIsIGVyciwgb3V0 ICk7CiAgICAgcEFzeW5jLT5SZWxlYXNlKCk7CiAKK2ZpbmFsOgogICAgICpudW1fdm9scyA9IGNG cm96ZW5Wb2xzOwogICAgIGNGcm96ZW5Wb2xzID0gMDsKICAgICBnb3RvIGRvbmU7Cg== --_002_CDA41AD4179BTomokiSekiyamahdscom_--