From: Alexander Graf <agraf@suse.de>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450
Date: Tue, 2 Apr 2013 10:09:51 +0200 [thread overview]
Message-ID: <CDBC3DB5-6BED-4BBA-A62F-FCB0245CB76F@suse.de> (raw)
In-Reply-To: <1364558788-4795-2-git-send-email-chouteau@adacore.com>
On 29.03.2013, at 13:06, Fabien Chouteau wrote:
> According to the different user's manuals, the vector offset for system
> reset (both /HRESET and /SRESET) is 0x00100.
>
> This patch may break support of some executables, as the power-on start
> address may change. For a specific board, if the power-on start address
> is different than HRESET vector (i.e. 0x00000100 or 0xfff00100), this
> should be fixed in board's initialization code.
>
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
What about the other users of hreset_vector? Can we just remove the variable altogether?
Alex
> ---
> target-ppc/translate_init.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index ce5238b..2c9b477 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -2645,7 +2645,7 @@ static void init_excp_MPC5xx (CPUPPCState *env)
> env->ivor_mask = 0x0000FFF0UL;
> env->ivpr_mask = 0xFFFF0000UL;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2676,7 +2676,7 @@ static void init_excp_MPC8xx (CPUPPCState *env)
> env->ivor_mask = 0x0000FFF0UL;
> env->ivpr_mask = 0xFFFF0000UL;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2701,7 +2701,7 @@ static void init_excp_G2 (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_IABR] = 0x00001300;
> env->excp_vectors[POWERPC_EXCP_SMI] = 0x00001400;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2804,7 +2804,7 @@ static void init_excp_602 (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_WDT] = 0x00001500;
> env->excp_vectors[POWERPC_EXCP_EMUL] = 0x00001600;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2828,7 +2828,7 @@ static void init_excp_603 (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_IABR] = 0x00001300;
> env->excp_vectors[POWERPC_EXCP_SMI] = 0x00001400;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2873,7 +2873,7 @@ static void init_excp_7x0 (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_SMI] = 0x00001400;
> env->excp_vectors[POWERPC_EXCP_THERM] = 0x00001700;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2895,7 +2895,7 @@ static void init_excp_750cl (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_IABR] = 0x00001300;
> env->excp_vectors[POWERPC_EXCP_SMI] = 0x00001400;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2917,7 +2917,7 @@ static void init_excp_750cx (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_IABR] = 0x00001300;
> env->excp_vectors[POWERPC_EXCP_THERM] = 0x00001700;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2944,7 +2944,7 @@ static void init_excp_7x5 (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_SMI] = 0x00001400;
> env->excp_vectors[POWERPC_EXCP_THERM] = 0x00001700;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2969,7 +2969,7 @@ static void init_excp_7400 (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_VPUA] = 0x00001600;
> env->excp_vectors[POWERPC_EXCP_THERM] = 0x00001700;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> @@ -2996,7 +2996,7 @@ static void init_excp_7450 (CPUPPCState *env)
> env->excp_vectors[POWERPC_EXCP_SMI] = 0x00001400;
> env->excp_vectors[POWERPC_EXCP_VPUA] = 0x00001600;
> /* Hardware reset vector */
> - env->hreset_vector = 0xFFFFFFFCUL;
> + env->hreset_vector = 0x00000100UL;
> #endif
> }
>
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-04-02 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 12:06 [Qemu-devel] [PATCH 1/2] PPC: Remvove env->hreset_excp_prefix Fabien Chouteau
2013-03-29 12:06 ` [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450 Fabien Chouteau
2013-04-02 8:09 ` Alexander Graf [this message]
2013-04-02 7:53 ` Fabien Chouteau
2013-04-02 8:56 ` Alexander Graf
2013-04-02 8:10 ` Fabien Chouteau
2013-04-02 8:09 ` [Qemu-devel] [PATCH 1/2] PPC: Remvove env->hreset_excp_prefix Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CDBC3DB5-6BED-4BBA-A62F-FCB0245CB76F@suse.de \
--to=agraf@suse.de \
--cc=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).