From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMwHz-0004wx-OS for qemu-devel@nongnu.org; Tue, 02 Apr 2013 04:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMwHw-0001Ok-3D for qemu-devel@nongnu.org; Tue, 02 Apr 2013 04:09:55 -0400 Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Alexander Graf In-Reply-To: <1364558788-4795-2-git-send-email-chouteau@adacore.com> Date: Tue, 2 Apr 2013 10:09:51 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1364558788-4795-1-git-send-email-chouteau@adacore.com> <1364558788-4795-2-git-send-email-chouteau@adacore.com> Subject: Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 29.03.2013, at 13:06, Fabien Chouteau wrote: > According to the different user's manuals, the vector offset for = system > reset (both /HRESET and /SRESET) is 0x00100. >=20 > This patch may break support of some executables, as the power-on = start > address may change. For a specific board, if the power-on start = address > is different than HRESET vector (i.e. 0x00000100 or 0xfff00100), this > should be fixed in board's initialization code. >=20 > Signed-off-by: Fabien Chouteau What about the other users of hreset_vector? Can we just remove the = variable altogether? Alex > --- > target-ppc/translate_init.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index ce5238b..2c9b477 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -2645,7 +2645,7 @@ static void init_excp_MPC5xx (CPUPPCState *env) > env->ivor_mask =3D 0x0000FFF0UL; > env->ivpr_mask =3D 0xFFFF0000UL; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2676,7 +2676,7 @@ static void init_excp_MPC8xx (CPUPPCState *env) > env->ivor_mask =3D 0x0000FFF0UL; > env->ivpr_mask =3D 0xFFFF0000UL; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2701,7 +2701,7 @@ static void init_excp_G2 (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_IABR] =3D 0x00001300; > env->excp_vectors[POWERPC_EXCP_SMI] =3D 0x00001400; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2804,7 +2804,7 @@ static void init_excp_602 (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_WDT] =3D 0x00001500; > env->excp_vectors[POWERPC_EXCP_EMUL] =3D 0x00001600; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2828,7 +2828,7 @@ static void init_excp_603 (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_IABR] =3D 0x00001300; > env->excp_vectors[POWERPC_EXCP_SMI] =3D 0x00001400; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2873,7 +2873,7 @@ static void init_excp_7x0 (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_SMI] =3D 0x00001400; > env->excp_vectors[POWERPC_EXCP_THERM] =3D 0x00001700; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2895,7 +2895,7 @@ static void init_excp_750cl (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_IABR] =3D 0x00001300; > env->excp_vectors[POWERPC_EXCP_SMI] =3D 0x00001400; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2917,7 +2917,7 @@ static void init_excp_750cx (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_IABR] =3D 0x00001300; > env->excp_vectors[POWERPC_EXCP_THERM] =3D 0x00001700; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2944,7 +2944,7 @@ static void init_excp_7x5 (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_SMI] =3D 0x00001400; > env->excp_vectors[POWERPC_EXCP_THERM] =3D 0x00001700; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2969,7 +2969,7 @@ static void init_excp_7400 (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_VPUA] =3D 0x00001600; > env->excp_vectors[POWERPC_EXCP_THERM] =3D 0x00001700; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > @@ -2996,7 +2996,7 @@ static void init_excp_7450 (CPUPPCState *env) > env->excp_vectors[POWERPC_EXCP_SMI] =3D 0x00001400; > env->excp_vectors[POWERPC_EXCP_VPUA] =3D 0x00001600; > /* Hardware reset vector */ > - env->hreset_vector =3D 0xFFFFFFFCUL; > + env->hreset_vector =3D 0x00000100UL; > #endif > } >=20 > --=20 > 1.7.9.5 >=20