From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37227)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UftXg-0007iw-U5
	for qemu-devel@nongnu.org; Fri, 24 May 2013 11:04:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UftXU-0006sl-SM
	for qemu-devel@nongnu.org; Fri, 24 May 2013 11:04:28 -0400
Received: from usindpps06.hds.com ([207.126.252.19]:55034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UftXU-0006rl-4I
	for qemu-devel@nongnu.org; Fri, 24 May 2013 11:04:16 -0400
From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Date: Fri, 24 May 2013 14:33:04 +0000
Message-ID: <CDC4F216.29C3%Tomoki.Sekiyama@hds.com>
In-Reply-To: <519F649D.6050405@redhat.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C5C7B304699D0F41AA6B33D8B26B1B12@hds.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while
 compiling with c++ compilier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "mdroth@linux.vnet.ibm.com" <mdroth@linux.vnet.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "vrozenfe@redhat.com" <vrozenfe@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, Seiji Aguchi <seiji.aguchi@hds.com>, "areis@redhat.com" <areis@redhat.com>

On 5/24/13 9:01 , "Laszlo Ersek" <lersek@redhat.com> wrote:

>On 05/21/13 17:33, Tomoki Sekiyama wrote:
>
>> diff --git a/scripts/qapi.py b/scripts/qapi.py
>> index afc5f32..b174acb 100644
>> --- a/scripts/qapi.py
>> +++ b/scripts/qapi.py
>> @@ -156,9 +156,16 @@ def c_var(name, protect=3DTrue):
>>      # GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.html
>>      # excluding _.*
>>      gcc_words =3D set(['asm', 'typeof'])
>> +    # C++ ISO/IEC 14882:2003 2.11
>> +    cpp_words =3D set(['bool', 'catch', 'class', 'const_cast', 'delete'=
,
>> +                     'dynamic_cast', 'explicit', 'false', 'friend',
>>'mutable',
>> +                     'namespace', 'new', 'operator', 'private',
>>'protected',
>> +                     'public', 'reinterpret_cast', 'static_cast',
>>'template',
>> +                     'this', 'throw', 'true', 'try', 'typeid',
>>'typename',
>> +                     'using', 'virtual', 'wchar_t'])
>>      # namespace pollution:
>>      polluted_words =3D set(['unix'])
>> -    if protect and (name in c89_words | c99_words | c11_words |
>>gcc_words | polluted_words):
>> +    if protect and (name in c89_words | c99_words | c11_words |
>>gcc_words | cpp_words | polluted_words):
>>          return "q_" + name
>>      return name.replace('-', '_').lstrip("*")
>
>Since you're respinning anyway, perhaps consider adding these lovely
>"alternative representations" from just one paragraph below (they are
>reserved and "shall not be used otherwise" than the operators they stand
>for):
>
>and	bitand	compl	not_eq	or_eq	xor_eq
>and_eq	bitor	not	or	xor
>
>although probably noone would use these as identifiers or otherwise...
>So just mentioning it for completeness.
>
>Laszlo

OK, I will try adding these keywords in next submit.

Thanks,
Tomoki Sekiyama