From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhNNB-0006Sd-1O for qemu-devel@nongnu.org; Fri, 15 Nov 2013 12:40:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhNN5-000618-8Q for qemu-devel@nongnu.org; Fri, 15 Nov 2013 12:40:00 -0500 Received: from usindpps05.hds.com ([207.126.252.18]:56976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhNN5-00060A-2n for qemu-devel@nongnu.org; Fri, 15 Nov 2013 12:39:55 -0500 From: Tomoki Sekiyama Date: Fri, 15 Nov 2013 17:39:45 +0000 Message-ID: In-Reply-To: <52761E95.7080204@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: [Qemu-devel] Ping [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" , "mdroth@linux.vnet.ibm.com" Cc: Gal Hammer , "lcapitulino@redhat.com" , "pbonzini@redhat.com" , Seiji Aguchi , "areis@redhat.com" On 11/3/13 3:59 , "Gal Hammer" wrote: >Reviewed-by: Gal Hammer > >On 01/11/2013 23:47, Tomoki Sekiyama wrote: >> Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze >>when >> no user is logging in to Windows, with an error message: >> {"error":{"class":"GenericError", >> "desc":"failed to add C:\\ to snapshotset: (error: >>8004230f)"}} >> >> To enable guest-fsfreeze-freeze/thaw without logging in users, this >>installs >> a service to execute qemu-ga VSS provider COM+ application that has full >> access privileges to the local system. The service will automatically be >> removed when the COM+ application is deregistered. >> >> This patch replaces ICOMAdminCatalog interface with ICOMAdminCatalog2 >> interface that contains CreateServiceForApplication() method in >>addition. >> >> Signed-off-by: Tomoki Sekiyama >> --- >> qga/vss-win32/install.cpp | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp >> index 37731a7..b791a6c 100644 >> --- a/qga/vss-win32/install.cpp >> +++ b/qga/vss-win32/install.cpp >> @@ -25,8 +25,8 @@ extern HINSTANCE g_hinstDll; >> >> const GUID CLSID_COMAdminCatalog =3D { 0xF618C514, 0xDFB8, 0x11d1, >> {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} }; >> -const GUID IID_ICOMAdminCatalog =3D { 0xDD662187, 0xDFC2, 0x11d1, >> - {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} }; >> +const GUID IID_ICOMAdminCatalog2 =3D { 0x790C6E0B, 0x9194, 0x4cc9, >> + {0x94, 0x26, 0xA4, 0x8A, 0x63, 0x18, 0x56, 0x96} }; >> const GUID CLSID_WbemLocator =3D { 0x4590f811, 0x1d3a, 0x11d0, >> {0x89, 0x1f, 0x00, 0xaa, 0x00, 0x4b, 0x2e, 0x24} }; >> const GUID IID_IWbemLocator =3D { 0xdc12a687, 0x737f, 0x11cf, >> @@ -141,7 +141,7 @@ static HRESULT QGAProviderFind( >> HRESULT hr; >> COMInitializer initializer; >> COMPointer pUnknown; >> - COMPointer pCatalog; >> + COMPointer pCatalog; >> COMPointer pColl; >> COMPointer pObj; >> _variant_t var; >> @@ -149,7 +149,7 @@ static HRESULT QGAProviderFind( >> >> chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, >>CLSCTX_INPROC_SERVER, >> IID_IUnknown, (void **)pUnknown.replace())); >> - chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog, >> + chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2, >> (void **)pCatalog.replace())); >> chk(pCatalog->GetCollection(_bstr_t(L"Applications"), >> (IDispatch **)pColl.replace())); >> @@ -206,7 +206,7 @@ STDAPI COMRegister(void) >> HRESULT hr; >> COMInitializer initializer; >> COMPointer pUnknown; >> - COMPointer pCatalog; >> + COMPointer pCatalog; >> COMPointer pApps, pRoles, pUsersInRole; >> COMPointer pObj; >> long n; >> @@ -229,7 +229,7 @@ STDAPI COMRegister(void) >> >> chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, >>CLSCTX_INPROC_SERVER, >> IID_IUnknown, (void **)pUnknown.replace())); >> - chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog, >> + chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2, >> (void **)pCatalog.replace())); >> >> /* Install COM+ Component */ >> @@ -273,6 +273,10 @@ STDAPI COMRegister(void) >> goto out; >> } >> >> + chk(pCatalog->CreateServiceForApplication( >> + _bstr_t(QGA_PROVIDER_LNAME), _bstr_t(QGA_PROVIDER_LNAME), >> + _bstr_t(L"SERVICE_AUTO_START"), >>_bstr_t(L"SERVICE_ERROR_NORMAL"), >> + _bstr_t(L""), _bstr_t(L".\\localsystem"), _bstr_t(L""), >>FALSE)); >> chk(pCatalog->InstallComponent(_bstr_t(QGA_PROVIDER_LNAME), >> _bstr_t(dllPath), _bstr_t(tlbPath), >> _bstr_t(""))); Ping? --=20 Tomoki Sekiyama