From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Harsh Prateek Bora" <harshpb@linux.ibm.com>, <qemu-ppc@nongnu.org>
Cc: <qemu-devel@nongnu.org>
Subject: Re: [RFC PATCH 4/4] spapr: Move spapr nested HV to a new file
Date: Sat, 13 May 2023 13:32:00 +1000 [thread overview]
Message-ID: <CSKU02SMVA44.82WP8MS5AJLB@wheely> (raw)
In-Reply-To: <a887b256-a411-4c20-dea8-f86eeaf6f965@linux.ibm.com>
On Fri May 5, 2023 at 9:09 PM AEST, Harsh Prateek Bora wrote:
> <correcting my email in CC>
>
> On 5/3/23 06:09, Nicholas Piggin wrote:
> > Create spapr_nested.c for the nested HV implementation (modulo small
> > pieces in MMU and exception handling).
> >
> This separation of nested code in its own file is very much needed, but
> this could have been a pre-patch to all the previous patches (at least
> 2/3, 3/4 which are debatable).
It could have. I don't mind getting it into a slightly better shape
before doing the rename but I don't know if there is really a one true
way for ordering code movement vs reworking.
Thanks,
Nick
prev parent reply other threads:[~2023-05-13 3:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 0:39 [RFC PATCH 0/4] spapr: clean up nested hv Nicholas Piggin
2023-05-03 0:39 ` [RFC PATCH 1/4] spapr: H_ENTER_NESTED should restore host XER ca field Nicholas Piggin
2023-05-05 10:20 ` Harsh Prateek Bora
2023-05-03 0:39 ` [RFC PATCH 2/4] spapr: Add a nested state struct Nicholas Piggin
2023-05-05 10:54 ` Harsh Prateek Bora
2023-05-13 3:27 ` Nicholas Piggin
2023-05-03 0:39 ` [RFC PATCH 3/4] spapr: load and store l2 state with helper functions Nicholas Piggin
2023-05-05 11:03 ` Harsh Prateek Bora
2023-05-13 3:30 ` Nicholas Piggin
2023-05-03 0:39 ` [RFC PATCH 4/4] spapr: Move spapr nested HV to a new file Nicholas Piggin
2023-05-05 11:09 ` Harsh Prateek Bora
2023-05-13 3:32 ` Nicholas Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CSKU02SMVA44.82WP8MS5AJLB@wheely \
--to=npiggin@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).