Re: [PULL v2 00/35] ppc queue

["Nicholas Piggin" <npiggin@gmail.com>]

On Fri Sep 8, 2023 at 8:15 AM AEST, Cédric Le Goater wrote:
> On 9/7/23 21:10, Michael Tokarev wrote:
> > 06.09.2023 17:36, Cédric Le Goater wrote:
> > ...
> >> ppc queue :
> >>
> >> * debug facility improvements
> >> * timebase and decrementer fixes
> >> * record-replay fixes
> >> * TCG fixes
> >> * XIVE model improvements for multichip
> >>
> >> ----------------------------------------------------------------
> >> Cédric Le Goater (4):
> >>        ppc/xive: Use address_space routines to access the machine RAM
> >>        ppc/xive: Introduce a new XiveRouter end_notify() handler
> >>        ppc/xive: Handle END triggers between chips with MMIOs
> >>        ppc/xive: Add support for the PC MMIOs
> >>
> >> Joel Stanley (1):
> >>        ppc: Add stub implementation of TRIG SPRs
> >>
> >> Maksim Kostin (1):
> >>        hw/ppc/e500: fix broken snapshot replay
> >>
> >> Nicholas Piggin (26):
> >>        target/ppc: Remove single-step suppression inside 0x100-0xf00
> >>        target/ppc: Improve book3s branch trace interrupt for v2.07S
> >>        target/ppc: Suppress single step interrupts on rfi-type instructions
> >>        target/ppc: Implement breakpoint debug facility for v2.07S
> >>        target/ppc: Implement watchpoint debug facility for v2.07S
> >>        spapr: implement H_SET_MODE debug facilities
> >>        ppc/vhyp: reset exception state when handling vhyp hcall
> >>        ppc/vof: Fix missed fields in VOF cleanup
> >>        hw/ppc/ppc.c: Tidy over-long lines
> >>        hw/ppc: Introduce functions for conversion between timebase and nanoseconds
> >>        host-utils: Add muldiv64_round_up
> >>        hw/ppc: Round up the decrementer interval when converting to ns
> >>        hw/ppc: Avoid decrementer rounding errors
> >>        target/ppc: Sign-extend large decrementer to 64-bits
> >>        hw/ppc: Always store the decrementer value
> >>        target/ppc: Migrate DECR SPR
> >>        hw/ppc: Reset timebase facilities on machine reset
> >>        hw/ppc: Read time only once to perform decrementer write
> >>        target/ppc: Fix CPU reservation migration for record-replay
> >>        target/ppc: Fix timebase reset with record-replay
> >>        spapr: Fix machine reset deadlock from replay-record
> >>        spapr: Fix record-replay machine reset consuming too many events
> >>        tests/avocado: boot ppc64 pseries replay-record test to Linux VFS mount
> >>        tests/avocado: reverse-debugging cope with re-executing breakpoints
> >>        tests/avocado: ppc64 reverse debugging tests for pseries and powernv
> >>        target/ppc: Fix LQ, STQ register-pair order for big-endian
> >>
> >> Richard Henderson (1):
> >>        target/ppc: Flush inputs to zero with NJ in ppc_store_vscr
> >>
> >> Shawn Anastasio (1):
> >>        target/ppc: Generate storage interrupts for radix RC changes
> >>
> >> jianchunfu (1):
> >>        target/ppc: Fix the order of kvm_enable judgment about kvmppc_set_interrupt()
> > 
> > Is there anything in there worth to pick for -stable?
> > Like, for example, some decrementer fixes, 
>
> The decrementer fixes are good candidates but there are quite a few
> patches and you might encounter conflicts.

Decrementer I was nervous about since there were quite a lot of
interacting issues. Decrementer has worked okay for a while, so
even though there are some bugs, they're mostly in edge cases
that most OSes don't hit or care so much about.

Possibly the decrementer migration patch could be a candidate.

In any case I would like them to get more testing upstream for
a while first.

>
> > or some of these:
> > 
> >   ppc/vof: Fix missed fields in VOF cleanup

vof patch I think is a candidate. Simple and fixes leaks.

> >   spapr: Fix machine reset deadlock from replay-record
> >   hw/ppc/e500: fix broken snapshot replay
>
> I can not tell if replay-record is important for stable. Nick ?

It seems to have been broken in many ways for long enough that
nobody was really using it (at least on pseries). Maybe e500
because an issue was filed for that and the fix looked small.

>   
> > or something else?
>
> These are :
>
>    target/ppc: Flush inputs to zero with NJ in ppc_store_vscr
>    target/ppc: Fix LQ, STQ register-pair order for big-endian

Yes definitely these two.

Thanks,
Nick