From: "Nicholas Piggin" <npiggin@gmail.com>
To: "BALATON Zoltan" <balaton@eik.bme.hu>, <qemu-devel@nongnu.org>,
<qemu-ppc@nongnu.org>
Cc: <clg@kaod.org>, "Greg Kurz" <groug@kaod.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>
Subject: Re: [PATCH v4 0/8] Misc clean ups to target/ppc exception handling
Date: Mon, 13 Nov 2023 20:34:23 +1000 [thread overview]
Message-ID: <CWXM7PTSELOP.3T6EQY4GSFR59@wheely> (raw)
In-Reply-To: <c5d4e1dd-5da9-8efe-20f4-4bcdc24357fe@eik.bme.hu>
On Wed Nov 1, 2023 at 8:44 PM AEST, BALATON Zoltan wrote:
> On Tue, 24 Oct 2023, BALATON Zoltan wrote:
> > These are some small clean ups for target/ppc/excp_helper.c trying to
> > make this code a bit simpler. No functional change is intended. This
> > series was submitted before but only partially merged due to freeze
> > and conflicting series os thia was postponed then to avoid conflicts.
>
> Ping?
May just leave this for next release, sorry.
I still didn't like the change to logging -- that's not intended to
print some machine implementation detail, but the address of the
instruction that caused the syscall/hcall. That could be changed
easily enough.
But I am also now in two minds about the change to nip too.
Synchronous interrupt is today handled here with nip at the address
of the instruction that caused it. That's *also* a nice invaraint to
have.
Other patches seem okay.
Thanks,
Nick
next prev parent reply other threads:[~2023-11-13 10:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 15:34 [PATCH v4 0/8] Misc clean ups to target/ppc exception handling BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 1/8] target/ppc: Use env_cpu for cpu_abort in excp_helper BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 2/8] target/ppc: Readability improvements in exception handlers BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 3/8] target/ppc: Fix gen_sc to use correct nip BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 4/8] target/ppc: Move patching nip from exception handler to helper_scv Nicholas Piggin
2023-10-24 15:52 ` BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 5/8] target/ppc: Simplify syscall exception handlers BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 6/8] target/ppc: Clean up ifdefs in excp_helper.c, part 1 BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 7/8] target/ppc: Clean up ifdefs in excp_helper.c, part 2 BALATON Zoltan
2023-10-24 15:34 ` [PATCH v4 8/8] target/ppc: Clean up ifdefs in excp_helper.c, part 3 BALATON Zoltan
2023-11-01 10:44 ` [PATCH v4 0/8] Misc clean ups to target/ppc exception handling BALATON Zoltan
2023-11-13 10:34 ` Nicholas Piggin [this message]
2023-11-13 12:08 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CWXM7PTSELOP.3T6EQY4GSFR59@wheely \
--to=npiggin@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).