From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80601C4332F for ; Mon, 13 Nov 2023 10:35:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2UH4-0004tP-M7; Mon, 13 Nov 2023 05:34:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UH2-0004sZ-N3; Mon, 13 Nov 2023 05:34:32 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2UH1-0003oL-3E; Mon, 13 Nov 2023 05:34:32 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1cc938f9612so25027835ad.1; Mon, 13 Nov 2023 02:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699871669; x=1700476469; darn=nongnu.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=59HHBygsX/8VsrY7VyDDRil1OBPfv2mut3ir82vY2fY=; b=Xiol+cJhgR0WGdF/xssC6L7rFhZlcuZcRHvwVF5kR8Z8eoOz1oTCM85nradn/nGCRv Tf+US0JBSnYQDOcxgpsojKqofaYxTW3nPUf6dLUuR+c/kqzkSxonMwzyOEizml0n2H9I 7IQNar256PwJhBsuukA2fkUzg9N2mw7/mvvdm+5SvLTZdqVeFE5K27uepYBlDhN8YBtY pRXKRFSWhbcvm9NH6fzuQ+s4OepladSk8C5NmTEvVc8rRtnlcmXoabJYRJL87FHU4oN+ aQ/lyJ3kDm5zTRXuxg3FIDv8//nZ49OeR4PE29XIqbouakwJaHUYpRzKKejmzJLk+E2l eKJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699871669; x=1700476469; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=59HHBygsX/8VsrY7VyDDRil1OBPfv2mut3ir82vY2fY=; b=hZb/2tgK+X83e/kdzCOW9j4G00CgUTeokhWbrWuoOQ1sAK+DYMCs58/E0LP9ra7kp6 GuzgnO4Go28ODna8NCQmRBxNKhqQZ58Ex7BOBd3dDHORmB98Wgknh9bAHEJ+7c9gs5Nc rCJme75BqDQfwikO3Q9vxR5Cr8/hHP60Hv7Q79U4dfUrvYzOqacyMeqJLl2Vqtw8+veP VoAhCDO4tAzIrmflHcXPiLvZu43IeVo04x15nq7HTshgYjWdDE2w6elDyzGFEj+j9gEY cD4cT9RkBE6WM+aALAxx0vEFMt4BhneqWnTkzD9XVtWiFooBRXa6gS6IgcbgtYdsSb81 TehQ== X-Gm-Message-State: AOJu0YxbnmFhJWhEriFjK0XiUC1kI96T3+bHY1vhhj+NSiE580c22c0z ePfl5Rlmt3Cb8NM5iRrdwc4= X-Google-Smtp-Source: AGHT+IGXTY5mTeQcO3VUSMaEw/pqZ/uluOjkkEyIXKf62Wfh/6XvrN3Prn//GeXKHTtVMWRYwZhojg== X-Received: by 2002:a17:903:32c1:b0:1cc:453f:517b with SMTP id i1-20020a17090332c100b001cc453f517bmr6129846plr.0.1699871669194; Mon, 13 Nov 2023 02:34:29 -0800 (PST) Received: from localhost (121-44-82-40.tpgi.com.au. [121.44.82.40]) by smtp.gmail.com with ESMTPSA id c5-20020a170902d90500b001bc5dc0cd75sm3745389plz.180.2023.11.13.02.34.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 02:34:28 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 13 Nov 2023 20:34:23 +1000 Message-Id: Cc: , "Greg Kurz" , "Daniel Henrique Barboza" Subject: Re: [PATCH v4 0/8] Misc clean ups to target/ppc exception handling From: "Nicholas Piggin" To: "BALATON Zoltan" , , X-Mailer: aerc 0.15.2 References: In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=npiggin@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed Nov 1, 2023 at 8:44 PM AEST, BALATON Zoltan wrote: > On Tue, 24 Oct 2023, BALATON Zoltan wrote: > > These are some small clean ups for target/ppc/excp_helper.c trying to > > make this code a bit simpler. No functional change is intended. This > > series was submitted before but only partially merged due to freeze > > and conflicting series os thia was postponed then to avoid conflicts. > > Ping? May just leave this for next release, sorry. I still didn't like the change to logging -- that's not intended to print some machine implementation detail, but the address of the instruction that caused the syscall/hcall. That could be changed easily enough. But I am also now in two minds about the change to nip too. Synchronous interrupt is today handled here with nip at the address of the instruction that caused it. That's *also* a nice invaraint to have. Other patches seem okay. Thanks, Nick