From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Chalapathi V" <chalapathi.v@linux.ibm.com>,
qemu-devel@nongnu.org
Cc: <qemu-ppc@nongnu.org>, <fbarrat@linux.ibm.com>,
<calebs@us.ibm.com>, <chalapathi.v@ibm.com>,
<saif.abrar@linux.vnet.ibm.com>
Subject: Re: [PATCH v5 3/3] hw/ppc: Nest1 chiplet wiring
Date: Fri, 24 Nov 2023 22:47:20 +1000 [thread overview]
Message-ID: <CX71XHZKBIK6.1MNARW3MTDJFT@wheely> (raw)
In-Reply-To: <bac39d18-e922-4979-9c52-216cad088483@kaod.org>
On Fri Nov 24, 2023 at 10:26 PM AEST, Cédric Le Goater wrote:
> On 11/24/23 12:28, Nicholas Piggin wrote:
> > On Fri Nov 24, 2023 at 8:15 PM AEST, Chalapathi V wrote:
> >> This part of the patchset connects the nest1 chiplet model to p10 chip.
> >
> > Seems fine to me. Should it just be squashed into patch 2?
>
> It is better to keep the model a part from the wiring because the
> same model could be plugged in different board/machine. It clarifies
> the interfaces, which should be limited to irq connects and memory
> mappings and it makes modeling shortcuts more visible: backpointers,
> looping on the machine mappings to find a core, etc.
Okay that makes sense.
> I didn't comment on the PnvChiptod proposal but it could/should
> be done the same.
I'll look at splitting it too then.
Thanks,
Nick
prev parent reply other threads:[~2023-11-24 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 10:15 [PATCH v5 0/3] pnv nest1 chiplet model Chalapathi V
2023-11-24 10:15 ` [PATCH v5 1/3] hw/ppc: Add pnv pervasive common chiplet units Chalapathi V
2023-11-24 11:12 ` Nicholas Piggin
2023-11-26 9:25 ` Chalapathi V
2023-11-24 10:15 ` [PATCH v5 2/3] hw/ppc: Add nest1 chiplet model Chalapathi V
2023-11-24 11:26 ` Nicholas Piggin
2023-11-24 12:19 ` Cédric Le Goater
2023-11-24 13:01 ` Nicholas Piggin
2023-11-26 9:29 ` Chalapathi V
2023-11-24 10:15 ` [PATCH v5 3/3] hw/ppc: Nest1 chiplet wiring Chalapathi V
2023-11-24 11:28 ` Nicholas Piggin
2023-11-24 12:26 ` Cédric Le Goater
2023-11-24 12:47 ` Nicholas Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CX71XHZKBIK6.1MNARW3MTDJFT@wheely \
--to=npiggin@gmail.com \
--cc=calebs@us.ibm.com \
--cc=chalapathi.v@ibm.com \
--cc=chalapathi.v@linux.ibm.com \
--cc=clg@kaod.org \
--cc=fbarrat@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=saif.abrar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).