qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org, "Anton Johansson" <anjo@rev.ng>
Cc: <qemu-ppc@nongnu.org>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Leandro Lupori" <leandro.lupori@eldorado.org.br>
Subject: Re: [PATCH] target/ppc/mmu-radix64: Use correct string format in walk_tree()
Date: Wed, 20 Mar 2024 15:02:04 +1000	[thread overview]
Message-ID: <CZYBAZXPSNVO.2TEDFF2Z4H56R@wheely> (raw)
In-Reply-To: <5f94eca5-8606-43d4-8599-89316d951e7e@linaro.org>

Thanks, I can put this in the ppc tree.

Thanks,
Nick

On Tue Mar 19, 2024 at 4:30 PM AEST, Philippe Mathieu-Daudé wrote:
> +Anton
>
> On 19/3/24 06:10, Philippe Mathieu-Daudé wrote:
> > 'mask', 'nlb' and 'base_addr' are all uin64_t types.
> > Use the corresponding PRIx64 format.
> > 
> > Fixes: d2066bc50d ("target/ppc: Check page dir/table base alignment")
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   target/ppc/mmu-radix64.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> > index 5823e039e6..690dff7a49 100644
> > --- a/target/ppc/mmu-radix64.c
> > +++ b/target/ppc/mmu-radix64.c
> > @@ -300,8 +300,8 @@ static int ppc_radix64_next_level(AddressSpace *as, vaddr eaddr,
> >   
> >           if (nlb & mask) {
> >               qemu_log_mask(LOG_GUEST_ERROR,
> > -                "%s: misaligned page dir/table base: 0x"TARGET_FMT_lx
> > -                " page dir size: 0x"TARGET_FMT_lx"\n",
> > +                "%s: misaligned page dir/table base: 0x%" PRIx64
> > +                " page dir size: 0x%" PRIx64 "\n",
> >                   __func__, nlb, mask + 1);
> >               nlb &= ~mask;
> >           }
> > @@ -324,8 +324,8 @@ static int ppc_radix64_walk_tree(AddressSpace *as, vaddr eaddr,
> >   
> >       if (base_addr & mask) {
> >           qemu_log_mask(LOG_GUEST_ERROR,
> > -            "%s: misaligned page dir base: 0x"TARGET_FMT_lx
> > -            " page dir size: 0x"TARGET_FMT_lx"\n",
> > +            "%s: misaligned page dir base: 0x%" PRIx64
> > +            " page dir size: 0x%" PRIx64 "\n",
> >               __func__, base_addr, mask + 1);
> >           base_addr &= ~mask;
> >       }



      reply	other threads:[~2024-03-20  5:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19  5:10 [PATCH] target/ppc/mmu-radix64: Use correct string format in walk_tree() Philippe Mathieu-Daudé
2024-03-19  6:30 ` Philippe Mathieu-Daudé
2024-03-20  5:02   ` Nicholas Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CZYBAZXPSNVO.2TEDFF2Z4H56R@wheely \
    --to=npiggin@gmail.com \
    --cc=anjo@rev.ng \
    --cc=danielhb413@gmail.com \
    --cc=leandro.lupori@eldorado.org.br \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).