* [PATCH] target/ppc/mmu-radix64: Use correct string format in walk_tree()
@ 2024-03-19 5:10 Philippe Mathieu-Daudé
2024-03-19 6:30 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-19 5:10 UTC (permalink / raw)
To: qemu-devel
Cc: Nicholas Piggin, qemu-ppc, Daniel Henrique Barboza,
Leandro Lupori, Philippe Mathieu-Daudé
'mask', 'nlb' and 'base_addr' are all uin64_t types.
Use the corresponding PRIx64 format.
Fixes: d2066bc50d ("target/ppc: Check page dir/table base alignment")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/ppc/mmu-radix64.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index 5823e039e6..690dff7a49 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -300,8 +300,8 @@ static int ppc_radix64_next_level(AddressSpace *as, vaddr eaddr,
if (nlb & mask) {
qemu_log_mask(LOG_GUEST_ERROR,
- "%s: misaligned page dir/table base: 0x"TARGET_FMT_lx
- " page dir size: 0x"TARGET_FMT_lx"\n",
+ "%s: misaligned page dir/table base: 0x%" PRIx64
+ " page dir size: 0x%" PRIx64 "\n",
__func__, nlb, mask + 1);
nlb &= ~mask;
}
@@ -324,8 +324,8 @@ static int ppc_radix64_walk_tree(AddressSpace *as, vaddr eaddr,
if (base_addr & mask) {
qemu_log_mask(LOG_GUEST_ERROR,
- "%s: misaligned page dir base: 0x"TARGET_FMT_lx
- " page dir size: 0x"TARGET_FMT_lx"\n",
+ "%s: misaligned page dir base: 0x%" PRIx64
+ " page dir size: 0x%" PRIx64 "\n",
__func__, base_addr, mask + 1);
base_addr &= ~mask;
}
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/ppc/mmu-radix64: Use correct string format in walk_tree()
2024-03-19 5:10 [PATCH] target/ppc/mmu-radix64: Use correct string format in walk_tree() Philippe Mathieu-Daudé
@ 2024-03-19 6:30 ` Philippe Mathieu-Daudé
2024-03-20 5:02 ` Nicholas Piggin
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-19 6:30 UTC (permalink / raw)
To: qemu-devel, Anton Johansson
Cc: Nicholas Piggin, qemu-ppc, Daniel Henrique Barboza,
Leandro Lupori
+Anton
On 19/3/24 06:10, Philippe Mathieu-Daudé wrote:
> 'mask', 'nlb' and 'base_addr' are all uin64_t types.
> Use the corresponding PRIx64 format.
>
> Fixes: d2066bc50d ("target/ppc: Check page dir/table base alignment")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/ppc/mmu-radix64.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 5823e039e6..690dff7a49 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -300,8 +300,8 @@ static int ppc_radix64_next_level(AddressSpace *as, vaddr eaddr,
>
> if (nlb & mask) {
> qemu_log_mask(LOG_GUEST_ERROR,
> - "%s: misaligned page dir/table base: 0x"TARGET_FMT_lx
> - " page dir size: 0x"TARGET_FMT_lx"\n",
> + "%s: misaligned page dir/table base: 0x%" PRIx64
> + " page dir size: 0x%" PRIx64 "\n",
> __func__, nlb, mask + 1);
> nlb &= ~mask;
> }
> @@ -324,8 +324,8 @@ static int ppc_radix64_walk_tree(AddressSpace *as, vaddr eaddr,
>
> if (base_addr & mask) {
> qemu_log_mask(LOG_GUEST_ERROR,
> - "%s: misaligned page dir base: 0x"TARGET_FMT_lx
> - " page dir size: 0x"TARGET_FMT_lx"\n",
> + "%s: misaligned page dir base: 0x%" PRIx64
> + " page dir size: 0x%" PRIx64 "\n",
> __func__, base_addr, mask + 1);
> base_addr &= ~mask;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] target/ppc/mmu-radix64: Use correct string format in walk_tree()
2024-03-19 6:30 ` Philippe Mathieu-Daudé
@ 2024-03-20 5:02 ` Nicholas Piggin
0 siblings, 0 replies; 3+ messages in thread
From: Nicholas Piggin @ 2024-03-20 5:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, Anton Johansson
Cc: qemu-ppc, Daniel Henrique Barboza, Leandro Lupori
Thanks, I can put this in the ppc tree.
Thanks,
Nick
On Tue Mar 19, 2024 at 4:30 PM AEST, Philippe Mathieu-Daudé wrote:
> +Anton
>
> On 19/3/24 06:10, Philippe Mathieu-Daudé wrote:
> > 'mask', 'nlb' and 'base_addr' are all uin64_t types.
> > Use the corresponding PRIx64 format.
> >
> > Fixes: d2066bc50d ("target/ppc: Check page dir/table base alignment")
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > target/ppc/mmu-radix64.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> > index 5823e039e6..690dff7a49 100644
> > --- a/target/ppc/mmu-radix64.c
> > +++ b/target/ppc/mmu-radix64.c
> > @@ -300,8 +300,8 @@ static int ppc_radix64_next_level(AddressSpace *as, vaddr eaddr,
> >
> > if (nlb & mask) {
> > qemu_log_mask(LOG_GUEST_ERROR,
> > - "%s: misaligned page dir/table base: 0x"TARGET_FMT_lx
> > - " page dir size: 0x"TARGET_FMT_lx"\n",
> > + "%s: misaligned page dir/table base: 0x%" PRIx64
> > + " page dir size: 0x%" PRIx64 "\n",
> > __func__, nlb, mask + 1);
> > nlb &= ~mask;
> > }
> > @@ -324,8 +324,8 @@ static int ppc_radix64_walk_tree(AddressSpace *as, vaddr eaddr,
> >
> > if (base_addr & mask) {
> > qemu_log_mask(LOG_GUEST_ERROR,
> > - "%s: misaligned page dir base: 0x"TARGET_FMT_lx
> > - " page dir size: 0x"TARGET_FMT_lx"\n",
> > + "%s: misaligned page dir base: 0x%" PRIx64
> > + " page dir size: 0x%" PRIx64 "\n",
> > __func__, base_addr, mask + 1);
> > base_addr &= ~mask;
> > }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-20 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19 5:10 [PATCH] target/ppc/mmu-radix64: Use correct string format in walk_tree() Philippe Mathieu-Daudé
2024-03-19 6:30 ` Philippe Mathieu-Daudé
2024-03-20 5:02 ` Nicholas Piggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).