From: Gary Hook <gary.hook@nimboxx.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "ehabkost@redhat.com" <ehabkost@redhat.com>,
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
"quintela@redhat.com" <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory
Date: Fri, 31 Oct 2014 21:08:24 +0000 [thread overview]
Message-ID: <D0796434.2A86%gary.hook@nimboxx.com> (raw)
In-Reply-To: <20141030122652.GA19349@grmbl.mre>
On 10/30/14, 7:26 AM, "Amit Shah" <amit.shah@redhat.com> wrote:
>On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> The migration code now occupies a fair chunk of the top level .c
>> files, it seems time to give it it's own directory.
>
>s/it's/its
6 out of 87 .c files, and approximately 370 blocks out of 2840 (based on
du output). 13% is a "fair chunk"?
But tidy organization is a good thing while needless renaming is not. The
only goal that the suggested renames would appear to accomplish is
additional obfuscation. How about just moving them into a subdirectory and
leave their names alone?
next prev parent reply other threads:[~2014-10-31 21:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 7:53 [Qemu-devel] [PATCH 0/3] More migration file cleanup Dr. David Alan Gilbert (git)
2014-10-16 7:53 ` [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory Dr. David Alan Gilbert (git)
2014-10-16 8:08 ` Juan Quintela
2014-10-16 8:12 ` Dr. David Alan Gilbert
2014-10-20 18:34 ` Paolo Bonzini
2014-10-16 8:08 ` Juan Quintela
2014-10-30 12:26 ` Amit Shah
2014-10-31 21:08 ` Gary Hook [this message]
2014-11-03 8:53 ` Dr. David Alan Gilbert
2014-11-03 12:32 ` Eduardo Habkost
2014-10-30 12:28 ` Amit Shah
2014-10-30 12:37 ` Dr. David Alan Gilbert
2014-10-30 12:46 ` Amit Shah
2014-10-31 23:31 ` Peter Maydell
2014-10-31 18:32 ` Peter Maydell
2014-10-31 18:58 ` Dr. David Alan Gilbert
2014-10-16 7:53 ` [Qemu-devel] [PATCH 2/3] Split struct QEMUFile out Dr. David Alan Gilbert (git)
2014-10-16 8:09 ` Juan Quintela
2014-10-30 12:34 ` Amit Shah
2014-10-16 7:53 ` [Qemu-devel] [PATCH 3/3] Split the QEMU buffered file code out Dr. David Alan Gilbert (git)
2014-10-16 8:10 ` Juan Quintela
2014-10-30 12:35 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0796434.2A86%gary.hook@nimboxx.com \
--to=gary.hook@nimboxx.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).