From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gary.hook@nimboxx.com>) id 1XkJR0-0008Iu-Cw
	for qemu-devel@nongnu.org; Fri, 31 Oct 2014 17:08:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gary.hook@nimboxx.com>) id 1XkJQq-0000VW-NA
	for qemu-devel@nongnu.org; Fri, 31 Oct 2014 17:08:38 -0400
Received: from mail-by2on0123.outbound.protection.outlook.com
	([207.46.100.123]:52832
	helo=na01-by2-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gary.hook@nimboxx.com>) id 1XkJQq-0000V8-CI
	for qemu-devel@nongnu.org; Fri, 31 Oct 2014 17:08:28 -0400
From: Gary Hook <gary.hook@nimboxx.com>
Date: Fri, 31 Oct 2014 21:08:24 +0000
Message-ID: <D0796434.2A86%gary.hook@nimboxx.com>
References: <1413446034-25167-1-git-send-email-dgilbert@redhat.com>
	<1413446034-25167-2-git-send-email-dgilbert@redhat.com>
	<20141030122652.GA19349@grmbl.mre>
In-Reply-To: <20141030122652.GA19349@grmbl.mre>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <553C7FCCB26C4749BFC0D28A6761ADC5@namprd02.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a
 migration directory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "ehabkost@redhat.com" <ehabkost@redhat.com>, "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>, "quintela@redhat.com" <quintela@redhat.com>



On 10/30/14, 7:26 AM, "Amit Shah" <amit.shah@redhat.com> wrote:

>On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>=20
>> The migration code now occupies a fair chunk of the top level .c
>> files, it seems time to give it it's own directory.
>
>s/it's/its

6 out of 87 .c files, and approximately 370 blocks out of 2840 (based on
du output). 13% is a "fair chunk"?

But tidy organization is a good thing while needless renaming is not. The
only goal that the suggested renames would appear to accomplish is
additional obfuscation. How about just moving them into a subdirectory and
leave their names alone?