Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

[Gary Hook <gary.hook@nimboxx.com>]

On 11/13/14, 11:03 AM, "Eric Blake" <eblake@redhat.com> wrote:

>On 11/13/2014 09:44 AM, Gary Hook wrote:
>
>[metacomment]
>
>> On 11/13/14, 6:46 AM, "Markus Armbruster"
>><armbru@redhat.com<mailto:armbru@redhat.com>> wrote:
>> 
>> Stefan Hajnoczi <stefanha@gmail.com<mailto:stefanha@gmail.com>> writes:
>> 
>> On Wed, Nov 12, 2014 at 06:48:18PM +0000, Gary Hook wrote:
>
>Your quoting style leaves a lot to be desired.  While you correctly
>attributed multiple contributors of the material quoted below...
>
>> -    return qemu_ftell(f) - last_ftell;
>> +    delta_ftell = qemu_ftell(f) - last_ftell;
>> +    return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 );
>> 
>> Good find!
>> 
>> Please don't nest the ternary operator, it is hard to read.
>> 
>> if (delta_ftell < 0) {
>>      return -1;
>> } else if (delta_ftell > 0) {
>>      return 1;
>> } else {
>>      return 0;
>> }
>> 
>> Bah, that's for wimps ;)
>> 
>>     return (delta_ftell > 0) - (delta_ftell < 0);
>> 
>> Look ma, no branches!
>> 
>> Ha-ha! Very good, but even less readable than the compressed ternary
>>version,
>> IMO. This function only gets called once per migration; I don't see a
>>few branches as performance-critical and worth the sacrifice of clarity
>>as to intent.
>
>...all three sets of contributions were listed with NO differentiation
>in indentation or leading '>' or other indication which part was quoted
>vs. which part was new material from you.  Most people on this list use
>a REAL mail agent (such as mutt or Thunderbird), and avoid web mail,
>precisely because most web mail implementations are absolutely lousy at
>writing decently threaded conversations.
>
>-- 
>Eric Blake   eblake redhat com    +1-919-301-3266
>Libvirt virtualization library http://libvirt.org

Son of aŠ.  You¹re absolutely right. Outlook is not helping me out here at
all. Mea culpa. I never used to have this problem with xmh.

I¹ll pay more attention going forward.