From: Bernhard Beschow <shentey@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-ppc@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH v4 0/4] hw/audio/pcspk: Inline pcspk_init()
Date: Sun, 22 Oct 2023 22:23:14 +0000 [thread overview]
Message-ID: <D0ECDB9D-F04B-46F5-BFE6-94257FB4FF65@gmail.com> (raw)
In-Reply-To: <20231020171509.87839-1-philmd@linaro.org>
Am 20. Oktober 2023 17:15:04 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>:
>Unfortunately v2 was merged as commit 40f8214fcd,
>so adapt v3 to clean the mess.
>
>Philippe Mathieu-Daudé (4):
> hw/i386/pc: Pass Error** argument to pc_basic_device_init()
> hw/i386/pc: Propagate error if HPET device creation failed
> hw/i386/pc: Propagate error if PC_SPEAKER device creation failed
I'm not sure if I'd do these first three patches. The reason is that machines don't inherit from DeviceState and therefore don't have canonical methods such as realize() to propagate errors. Propagating the errors in the machine init helper methods seem a bit ad-hoc to me.
> hw/isa/i82378: Propagate error if PC_SPEAKER device creation failed
The reason I suggested use of `errp` here is that it is already a parameter.
Best regards,
Bernhard
>
> include/hw/i386/pc.h | 5 +++--
> hw/i386/pc.c | 15 +++++++++++----
> hw/i386/pc_piix.c | 2 +-
> hw/i386/pc_q35.c | 2 +-
> hw/isa/i82378.c | 4 +++-
> 5 files changed, 19 insertions(+), 9 deletions(-)
>
next prev parent reply other threads:[~2023-10-22 22:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 17:15 [PATCH v4 0/4] hw/audio/pcspk: Inline pcspk_init() Philippe Mathieu-Daudé
2023-10-20 17:15 ` [PATCH v4 1/4] hw/i386/pc: Pass Error** argument to pc_basic_device_init() Philippe Mathieu-Daudé
2023-10-22 16:59 ` Richard Henderson
2023-10-20 17:15 ` [PATCH v4 2/4] hw/i386/pc: Propagate error if HPET device creation failed Philippe Mathieu-Daudé
2023-10-22 17:01 ` Richard Henderson
2023-10-20 17:15 ` [PATCH v4 3/4] hw/i386/pc: Propagate error if PC_SPEAKER " Philippe Mathieu-Daudé
2023-10-22 17:01 ` Richard Henderson
2023-10-20 17:15 ` [PATCH v4 4/4] hw/isa/i82378: " Philippe Mathieu-Daudé
2023-10-22 17:02 ` Richard Henderson
2023-10-22 22:12 ` Bernhard Beschow
2023-10-22 22:23 ` Bernhard Beschow [this message]
2023-11-03 8:56 ` [PATCH v4 0/4] hw/audio/pcspk: Inline pcspk_init() Markus Armbruster
2023-11-08 10:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0ECDB9D-F04B-46F5-BFE6-94257FB4FF65@gmail.com \
--to=shentey@gmail.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=hpoussin@reactos.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).