From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Richard Henderson" <richard.henderson@linaro.org>,
<qemu-ppc@nongnu.org>
Cc: <qemu-devel@nongnu.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Glenn Miles" <milesg@linux.vnet.ibm.com>
Subject: Re: [PATCH 05/14] target/ppc: Implement attn instruction on BookS 64-bit processors
Date: Mon, 20 May 2024 17:22:54 +1000 [thread overview]
Message-ID: <D1EAI24RN4GX.2MLW19HGNCJFQ@gmail.com> (raw)
In-Reply-To: <9e431f9a-10db-4fb2-b2b7-a4deeff5dfa5@linaro.org>
On Sat May 18, 2024 at 9:07 PM AEST, Richard Henderson wrote:
> On 5/18/24 11:31, Nicholas Piggin wrote:
> > +static void gen_attn(DisasContext *ctx)
> > +{
> > +#if defined(CONFIG_USER_ONLY)
> > + GEN_PRIV(ctx);
> > +#else
> > + gen_helper_attn(tcg_env);
> > +#endif
> > +}
>
> You forgot to check priv in system mode.
> Better as
>
> GEN_PRIV(ctx);
> #ifndef CONFIG_USER_ONLY
> gen_helper_attn(...)
> #endif
Good catch again.
I'm actually wrong there too, it should be treated as illegal
unless it is enabled with a system SPR, in which case it's
unprivileged (it can be inserted by external hardware debuggers
to stop the CPU and get notified).
Thanks,
Nick
next prev parent reply other threads:[~2024-05-20 7:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 9:31 [PATCH 00/14] target/ppc: Various TCG emulation patches Nicholas Piggin
2024-05-18 9:31 ` [PATCH 01/14] target/ppc: larx/stcx generation need only apply DEF_MEMOP() once Nicholas Piggin
2024-05-18 10:58 ` Richard Henderson
2024-05-18 9:31 ` [PATCH 02/14] target/ppc: Remove redundant MEMOP_GET_SIZE macro Nicholas Piggin
2024-05-18 9:57 ` BALATON Zoltan
2024-05-18 10:59 ` Richard Henderson
2024-05-18 9:31 ` [PATCH 03/14] target/ppc: Make checkstop actually stop the system Nicholas Piggin
2024-05-18 9:31 ` [PATCH 04/14] target/ppc: improve checkstop logging Nicholas Piggin
2024-05-18 9:31 ` [PATCH 05/14] target/ppc: Implement attn instruction on BookS 64-bit processors Nicholas Piggin
2024-05-18 11:05 ` Richard Henderson
2024-05-20 7:18 ` Nicholas Piggin
2024-05-18 11:07 ` Richard Henderson
2024-05-20 7:22 ` Nicholas Piggin [this message]
2024-05-18 9:31 ` [PATCH 06/14] target/ppc: BookE DECAR SPR is 32-bit Nicholas Piggin
2024-05-18 9:31 ` [PATCH 07/14] target/ppc: Wire up BookE ATB registers for e500 family Nicholas Piggin
2024-05-18 9:31 ` [PATCH 08/14] target/ppc: Add PPR32 SPR Nicholas Piggin
2024-05-18 9:31 ` [PATCH 09/14] target/ppc: add helper to write per-LPAR SPRs Nicholas Piggin
2024-05-18 11:26 ` Richard Henderson
2024-05-20 7:23 ` Nicholas Piggin
2024-05-18 9:31 ` [PATCH 10/14] target/ppc: Add SMT support to simple SPRs Nicholas Piggin
2024-05-18 9:31 ` [PATCH 11/14] target/ppc: Add SMT support to PTCR SPR Nicholas Piggin
2024-05-18 9:31 ` [PATCH 12/14] target/ppc: Implement LDBAR, TTR SPRs Nicholas Piggin
2024-05-18 9:31 ` [PATCH 13/14] target/ppc: Implement SPRC/SPRD SPRs Nicholas Piggin
2024-05-18 9:31 ` [PATCH 14/14] target/ppc: add SMT support to msgsnd broadcast Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1EAI24RN4GX.2MLW19HGNCJFQ@gmail.com \
--to=npiggin@gmail.com \
--cc=danielhb413@gmail.com \
--cc=milesg@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).