From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB047C636D7 for ; Tue, 21 Feb 2023 15:42:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUUlE-0003pg-Np; Tue, 21 Feb 2023 10:40:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUUlC-0003pJ-GB; Tue, 21 Feb 2023 10:40:54 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUUlA-0002Yw-Fn; Tue, 21 Feb 2023 10:40:54 -0500 Received: by mail-ed1-x52f.google.com with SMTP id ec43so18365153edb.8; Tue, 21 Feb 2023 07:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=H1bpPrODuziI2gv8GS5X7KS5wVzcUhNRmx8X/4c+YOE=; b=aiuXJ2r2XS6cYY4Kw9AI0+went2w/yLCZwlD8IksWzyPydSRiDCOKsVPzOc5FtqNzJ 6nbEWeCF1D+LEDeXcdvlTRYkcaDpZhhg+VSWZcMq7rjq8lI/ET+JQ9PHnwixsye4CGTx OIYZTBVPH1ut3/ssbOehifvoUYkVzueonwbPKEP8MKc4H/gkIcqk20QrLJDGZepqrmVC o0SvEtJ0cMs9i5Ym23Qkgw4ySVq781oqqPNDTjaMAsjdMPNSizLWquzP97Vl9pLhIcMY FNWMsPVisZqTqvv6K+5Y6OjB5Q4EbYrUSehz7Il0FsocA2UVwJ2pO6HfpefjBX3g8kbM dT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H1bpPrODuziI2gv8GS5X7KS5wVzcUhNRmx8X/4c+YOE=; b=qsIvB8cNfSLnB6kLnmgyeEsG3WzyyAONsmrXsKyiwhUi00w4ttduMgzoh15kR7uRPR h5Sx/dm/xuOGh2ZJ2kTzCp7l81dP/LX8pUAGmug4GKdDt6FicezVrwzUJKSq4quYw490 Kfauw5Qq9qh59YGQ+ErKP6JeiaevgEbjqikjybGYUyKjcxqraVAV+Pgj6Axtn1pD5rzI nhNY0/COG7ZRHl6G4Kh5ye1iTPW7cVqxifXO3zpUsTyZZVe0Z5MJA7g+6KX7x67bhq7a O9NKNa8CMAS8JjpnE8dDoBEWK4/4bVVV3p2/pKPnXQIhIkdL+OKqFwbq4DsdFRrhzCCa F7qw== X-Gm-Message-State: AO0yUKXbdiaUO2EtPQSQRfTDnTTiTz/07s9O0FgX9tcyLNVkZbLzFDj0 qlI/kUhFXHkQlEGcFx4tQZ/SDS3eiQg= X-Google-Smtp-Source: AK7set/jb16MNex1jrZOz0vyPhwmoyeysnS2aYv+m1kvSUZxLn4A4sjtKkBvXq+lroOAjx8mEb5gRA== X-Received: by 2002:a17:906:2413:b0:86c:a3ed:1442 with SMTP id z19-20020a170906241300b0086ca3ed1442mr11689330eja.4.1676994050258; Tue, 21 Feb 2023 07:40:50 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf06ee000cdc023a29c679bc.dip0.t-ipconnect.de. [2003:fa:af06:ee00:cdc:23a:29c6:79bc]) by smtp.gmail.com with ESMTPSA id cb3-20020a170906a44300b008d83ad86fe8sm2184828ejb.59.2023.02.21.07.40.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 07:40:49 -0800 (PST) Date: Tue, 21 Feb 2023 15:40:45 +0000 From: Bernhard Beschow To: qemu-devel@nongnu.org CC: Paolo Bonzini , Sunil Muthuswamy , "Michael S. Tsirkin" , Marcel Apfelbaum , "Dr . David Alan Gilbert" , qemu-trivial@nongnu.org, Richard Henderson , Juan Quintela , Eduardo Habkost , Thomas Huth , Igor Mammedov , BALATON Zoltan , Ani Sinha , Laurent Vivier Subject: Re: [PATCH v4 0/9] PC cleanups In-Reply-To: <20230213162004.2797-1-shentey@gmail.com> References: <20230213162004.2797-1-shentey@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=shentey@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 13=2E Februar 2023 16:19:55 UTC schrieb Bernhard Beschow : >This series contains some cleanups I came across when working on the PC > >machines=2E It consists of reducing the usage of global variables and eli= minating > >some redundancies=2E > > > >One notable change is that the SMRAM memory region gets moved from the i4= 40fx > >and q35 host bridges into the x86 machine=2E This will simplify cleaning = up these > >host bridges which will be done in a separate series=2E Note that the mov= ement of > >the SMRAM memory region apparently doesn't change migration ABI for the p= c and > >q35 machines (see below)=2E > Ping > > >Testing done: > >* `make check` > >' `make check-avocado` > >* `qemu-system-x86_64 -M q35 -m 2G -cdrom \ > > manjaro-kde-21=2E3=2E2-220704-linux515=2Eiso` > >* `qemu-system-x86_64 -M pc -m 2G -cdrom manjaro-kde-21=2E3=2E2-220704-li= nux515=2Eiso` > >* Confirm that JSON representation of migration files (pc & q35) are empt= y: > > 1=2E Create four migration files {pc,q35}-{before,after}=2Emig by runni= ng > > `qemu-system-x86_64 -M {pc,q35} -S` with QEMU built from master and = from > > this series=2E > > 2=2E Run `=2E/scripts/analyze-migration=2Epy -d desc -f *=2Emig > *=2Ej= son` on the four > > files > > 3=2E Compare the diffs -> both are empty > > > >v4: > >* Remove ram_memory variable in pc_q35 completely (Zoltan) > > > >v3: > >* Add three patches regarding init_pam() and SMRAM=2E > >* Drop 'hw/i386/pc_q35: Resolve redundant q35_host variable' since Phil p= osted > > a similar patch in a more comprehensive series: > > https://lore=2Ekernel=2Eorg/qemu-devel/20230203180914=2E49112-13-philmd= @linaro=2Eorg/ > >* Drop 'hw/isa/lpc_ich9: Reuse memory and io address space of PCI bus' si= nce > > it inadvertantly changed the memory hierarchy=2E > >* Drop ICH9 cleanups again in favor of a separate series=2E > > > >v2: > >* Factor out 'hw/i386/pc_q35: Reuse machine parameter' from 'hw/i386/pc_q= 35: > > Resolve redundant q35_host variable' (Zoltan) > >* Lower type of phb to Object in 'hw/i386/pc_q35: Resolve redundant q35_h= ost > > variable' (Zoltan) > >* Add ICH9 cleanups > > > >Bernhard Beschow (9): > > hw/pci-host/i440fx: Inline sysbus_add_io() > > hw/pci-host/q35: Inline sysbus_add_io() > > hw/i386/pc_q35: Reuse machine parameter > > hw/i386/pc_{q35,piix}: Reuse MachineClass::desc as SMB product name > > hw/i386/pc_{q35,piix}: Minimize usage of get_system_memory() > > hw/i386/pc: Initialize ram_memory variable directly > > hw/pci-host/pam: Make init_pam() usage more readable > > hw/i386/x86: Make TYPE_X86_MACHINE the owner of smram > > target/i386/tcg/sysemu/tcg-cpu: Avoid own opinion about smram size > > > > include/hw/i386/pc=2Eh | 1 - > > include/hw/i386/x86=2Eh | 2 ++ > > include/hw/pci-host/i440fx=2Eh | 7 ++++--- > > include/hw/pci-host/pam=2Eh | 5 +++-- > > include/hw/pci-host/q35=2Eh | 4 +++- > > hw/i386/pc=2Ec | 2 -- > > hw/i386/pc_piix=2Ec | 10 +++++----- > > hw/i386/pc_q35=2Ec | 17 +++++++++-------- > > hw/i386/x86=2Ec | 4 ++++ > > hw/pci-host/i440fx=2Ec | 28 +++++++++++++--------------- > > hw/pci-host/pam=2Ec | 12 ++++++------ > > hw/pci-host/q35=2Ec | 31 ++++++++++++++++--------------- = > > target/i386/tcg/sysemu/tcg-cpu=2Ec | 3 +-- > > 13 files changed, 66 insertions(+), 60 deletions(-) > > > >-- > >2=2E39=2E1 > > >