From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Michael Tokarev" <mjt@tls.msk.ru>, <qemu-ppc@nongnu.org>
Cc: "Daniel Henrique Barboza" <danielhb413@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
<qemu-devel@nongnu.org>, <qemu-stable@nongnu.org>
Subject: Re: [PATCH] spapr: Migrate ail-mode-3 spapr cap
Date: Thu, 04 Jul 2024 21:08:24 +1000 [thread overview]
Message-ID: <D2GPH8NDJC5N.W2ANEA2TF82V@gmail.com> (raw)
In-Reply-To: <793df53e-337c-46b0-be32-ced550002daf@tls.msk.ru>
On Mon Jul 1, 2024 at 5:10 PM AEST, Michael Tokarev wrote:
> 06.06.2024 14:26, Michael Tokarev wrote:
> > 06.05.2024 14:56, Nicholas Piggin wrote:
> >> This cap did not add the migration code when it was introduced. This
> >> results in migration failure when changing the default using the
> >> command line.
> >>
> >> Cc: qemu-stable@nongnu.org
> >> Fixes: ccc5a4c5e10 ("spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for H_SET_MODE hcall")
> >> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> >> ---
> >> include/hw/ppc/spapr.h | 1 +
> >> hw/ppc/spapr.c | 1 +
> >> hw/ppc/spapr_caps.c | 1 +
> >> 3 files changed, 3 insertions(+)
> >
> > Hi!
> >
> > Has this change been forgotten? It's aimed at -stable, so must be
> > fixing a real issue.
>
> Ping #2 ? :)
Ah sorry, I meant to deal with this before. But yes I did forget it in
the last PR and it does fix a migration issue. Thanks for the reminder
of it.
I'll send it in soon.
Thanks,
Nick
prev parent reply other threads:[~2024-07-04 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 11:56 [PATCH] spapr: Migrate ail-mode-3 spapr cap Nicholas Piggin
2024-05-07 4:12 ` Harsh Prateek Bora
2024-05-07 7:54 ` Philippe Mathieu-Daudé
2024-06-06 11:26 ` Michael Tokarev
2024-07-01 7:10 ` Michael Tokarev
2024-07-04 11:08 ` Nicholas Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2GPH8NDJC5N.W2ANEA2TF82V@gmail.com \
--to=npiggin@gmail.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).