Convert an error_report to tracepoint

Convert an error_report to tracepoint

[Anthony Harivel]

Hello, 

There is an error_report() in target/i386/kvm/vmsr_energy.c that would 
benefit for being a tracepoint because this is not actually an "error" 
as per se, but more a notification that could be used for debugging, and 
it is quite verbose.

Could someone give me some pointer on how I could manage that so I can 
send a patch to rectify this ?

Thanks,
Anthony

Re: Convert an error_report to tracepoint

[Daniel P. Berrangé]

On Mon, Sep 30, 2024 at 01:36:21PM +0200, Anthony Harivel wrote:
> Hello, 
> 
> There is an error_report() in target/i386/kvm/vmsr_energy.c that would 
> benefit for being a tracepoint because this is not actually an "error" 
> as per se, but more a notification that could be used for debugging, and 
> it is quite verbose.
> 
> Could someone give me some pointer on how I could manage that so I can 
> send a patch to rectify this ?

Modify the file target/i386/kvm/trace-events   to define your desired
tracepoint(s).

Then #include "trace-event.h"  in your vmsr_energy.c  file

Call your probepoint using  trace_{probe name}(...args...)

See docs/devel/tracing.rst for general info on tracing

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: Convert an error_report to tracepoint

[Anthony Harivel]

Daniel P. Berrangé, Sep 30, 2024 at 13:43:
> On Mon, Sep 30, 2024 at 01:36:21PM +0200, Anthony Harivel wrote:
>> Hello, 
>> 
>> There is an error_report() in target/i386/kvm/vmsr_energy.c that would 
>> benefit for being a tracepoint because this is not actually an "error" 
>> as per se, but more a notification that could be used for debugging, and 
>> it is quite verbose.
>> 
>> Could someone give me some pointer on how I could manage that so I can 
>> send a patch to rectify this ?
>
> Modify the file target/i386/kvm/trace-events   to define your desired
> tracepoint(s).
>
> Then #include "trace-event.h"  in your vmsr_energy.c  file
>
> Call your probepoint using  trace_{probe name}(...args...)
>
> See docs/devel/tracing.rst for general info on tracing
>

Right, I get it now !

Thanks a lot (again) for your support Daniel

> With regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|