* Convert an error_report to tracepoint
@ 2024-09-30 11:36 Anthony Harivel
2024-09-30 11:43 ` Daniel P. Berrangé
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Harivel @ 2024-09-30 11:36 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini
Hello,
There is an error_report() in target/i386/kvm/vmsr_energy.c that would
benefit for being a tracepoint because this is not actually an "error"
as per se, but more a notification that could be used for debugging, and
it is quite verbose.
Could someone give me some pointer on how I could manage that so I can
send a patch to rectify this ?
Thanks,
Anthony
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Convert an error_report to tracepoint
2024-09-30 11:36 Convert an error_report to tracepoint Anthony Harivel
@ 2024-09-30 11:43 ` Daniel P. Berrangé
2024-09-30 11:53 ` Anthony Harivel
0 siblings, 1 reply; 3+ messages in thread
From: Daniel P. Berrangé @ 2024-09-30 11:43 UTC (permalink / raw)
To: Anthony Harivel; +Cc: qemu-devel, pbonzini
On Mon, Sep 30, 2024 at 01:36:21PM +0200, Anthony Harivel wrote:
> Hello,
>
> There is an error_report() in target/i386/kvm/vmsr_energy.c that would
> benefit for being a tracepoint because this is not actually an "error"
> as per se, but more a notification that could be used for debugging, and
> it is quite verbose.
>
> Could someone give me some pointer on how I could manage that so I can
> send a patch to rectify this ?
Modify the file target/i386/kvm/trace-events to define your desired
tracepoint(s).
Then #include "trace-event.h" in your vmsr_energy.c file
Call your probepoint using trace_{probe name}(...args...)
See docs/devel/tracing.rst for general info on tracing
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Convert an error_report to tracepoint
2024-09-30 11:43 ` Daniel P. Berrangé
@ 2024-09-30 11:53 ` Anthony Harivel
0 siblings, 0 replies; 3+ messages in thread
From: Anthony Harivel @ 2024-09-30 11:53 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel, pbonzini
Daniel P. Berrangé, Sep 30, 2024 at 13:43:
> On Mon, Sep 30, 2024 at 01:36:21PM +0200, Anthony Harivel wrote:
>> Hello,
>>
>> There is an error_report() in target/i386/kvm/vmsr_energy.c that would
>> benefit for being a tracepoint because this is not actually an "error"
>> as per se, but more a notification that could be used for debugging, and
>> it is quite verbose.
>>
>> Could someone give me some pointer on how I could manage that so I can
>> send a patch to rectify this ?
>
> Modify the file target/i386/kvm/trace-events to define your desired
> tracepoint(s).
>
> Then #include "trace-event.h" in your vmsr_energy.c file
>
> Call your probepoint using trace_{probe name}(...args...)
>
> See docs/devel/tracing.rst for general info on tracing
>
Right, I get it now !
Thanks a lot (again) for your support Daniel
> With regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-30 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 11:36 Convert an error_report to tracepoint Anthony Harivel
2024-09-30 11:43 ` Daniel P. Berrangé
2024-09-30 11:53 ` Anthony Harivel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).