From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Cc: <qemu-ppc@nongnu.org>, <qemu-devel@nongnu.org>
Subject: Re: PING: [PATCH v2 0/2] target/ppc: Make divd[u] handler method decodetree compatible
Date: Tue, 08 Oct 2024 15:16:40 +1000 [thread overview]
Message-ID: <D4Q648828O0X.3AM47674H807M@gmail.com> (raw)
In-Reply-To: <c7416776312932df4e4c27cf040189fd098cba3c.camel@linux.ibm.com>
On Wed Sep 18, 2024 at 7:56 PM AEST, Ilya Leoshkevich wrote:
> On Mon, 2024-08-12 at 10:53 +0200, Ilya Leoshkevich wrote:
> > v1:
> > https://lore.kernel.org/qemu-devel/20240731100953.14950-1-iii@linux.ibm.com/
> > v1 -> v2: Add R-bs and a targeted divd[u] patch.
> >
> > Hi,
> >
> > This series contains two fixes for the same issue: divd[u] touching
> > uninitialized ctx->opcode.
> >
> > Patch 1 is a catch-all solution for all issues in this class. IMHO
> > it's worth having something like this until the legacy decoder is
> > fully eliminated.
> >
> > Patch 2 is a targeted fix for divd[u] only.
> >
> > Best regards,
> > Ilya
> >
> > Ilya Leoshkevich (2):
> > target/ppc: Set ctx->opcode for decode_insn32()
> > target/ppc: Make divd[u] handler method decodetree compatible
> >
> > target/ppc/translate.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
>
> Ping.
Hey Ilya,
Sorry for the late reply, had some time off and taken me a while
to get back to it.
Yeah this is a good fix, thank you. I have queued it.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Thanks,
Nick
prev parent reply other threads:[~2024-10-08 5:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 8:53 [PATCH v2 0/2] target/ppc: Make divd[u] handler method decodetree compatible Ilya Leoshkevich
2024-08-12 8:53 ` [PATCH v2 1/2] target/ppc: Set ctx->opcode for decode_insn32() Ilya Leoshkevich
2024-08-12 8:53 ` [PATCH v2 2/2] target/ppc: Make divd[u] handler method decodetree compatible Ilya Leoshkevich
2024-08-12 9:08 ` Richard Henderson
2024-08-12 14:03 ` Philippe Mathieu-Daudé
2024-09-18 9:56 ` PING: [PATCH v2 0/2] " Ilya Leoshkevich
2024-10-08 5:16 ` Nicholas Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4Q648828O0X.3AM47674H807M@gmail.com \
--to=npiggin@gmail.com \
--cc=danielhb413@gmail.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).