From: Alex Bligh <alex@alex.org.uk>
To: liu ping fan <qemulist@gmail.com>,
MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: Kevin Wolf <kwolf@redhat.com>,
pingfank@linux.vnet.ibm.com, sheepdog@lists.wpkg.org,
Alex Bligh <alex@alex.org.uk>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [sheepdog] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers
Date: Fri, 02 Aug 2013 10:35:10 +0100 [thread overview]
Message-ID: <D78291DC3661C5301C96AAD1@nimrod.local> (raw)
In-Reply-To: <CAJnKYQ=qKGVDwzO91FqfbiTK=TZ+X35p0WQ9DZEE-7nwoxMpKg@mail.gmail.com>
Pingfan,
--On 2 August 2013 16:19:31 +0800 liu ping fan <qemulist@gmail.com> wrote:
>> Okay, I'll update this patch based on the AioContext timer. I'm also
>> happy to help Alex and Pingfan to finish the implementation.
>>
> Alex, do you make a further step than V4? If you have, could you share
> it with us?So we can rebase our patches onto yours.
I've got no changes beyond v4 yet.
The changes I am thinking of making are:
1. changing the AioContext * in QEMUTimerList to be a pointer to a callback
instead. This is a tiny and self-contained change and may well be
unnecessary.
2. Whatever comes out of Paolo's long email of yesterday, the contents of
which I have not fully digested. However, I think what this boils down
to is calling *_notify slightly less often.
3. Someone (Paolo/Kevin?) suggested renaming the *new* timer functions
(i.e. the ones with timerlist in the name). That won't affect anything
current.
I suggest you go with v4 for the time being. If I end up doing a v5 and
your code doesn't sit well on top of it, I can rebase to yours or
something. I'd expect changes in v5 to be really small.
--
Alex Bligh
next prev parent reply other threads:[~2013-08-02 20:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 6:10 [Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 01/10] ignore SIGPIPE in qemu-img and qemu-io MORITA Kazutaka
2013-07-30 13:41 ` Stefan Hajnoczi
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 02/10] iov: handle EOF in iov_send_recv MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly MORITA Kazutaka
2013-07-30 13:48 ` Stefan Hajnoczi
2013-08-02 6:09 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 04/10] sheepdog: handle vdi objects in resend_aio_req MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 05/10] sheepdog: reload inode outside of resend_aioreq MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers MORITA Kazutaka
2013-07-30 13:58 ` Stefan Hajnoczi
2013-08-02 6:20 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-08-02 8:19 ` liu ping fan
2013-08-02 9:35 ` Alex Bligh [this message]
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 07/10] sheepdog: try to reconnect to sheepdog after network error MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 08/10] sheepdog: make add_aio_request and send_aioreq void functions MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 09/10] sheepdog: cancel aio requests if possible MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 10/10] sheepdog: check simultaneous create in resend_aioreq MORITA Kazutaka
2013-07-30 14:13 ` [Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D78291DC3661C5301C96AAD1@nimrod.local \
--to=alex@alex.org.uk \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=pbonzini@redhat.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).