From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46601)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1RgnJl-0004uR-NO
	for qemu-devel@nongnu.org; Fri, 30 Dec 2011 20:01:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1RgnJk-0005fM-QS
	for qemu-devel@nongnu.org; Fri, 30 Dec 2011 20:01:01 -0500
Received: from mailout-de.gmx.net ([213.165.64.22]:52172)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1RgnJk-0005fC-HD
	for qemu-devel@nongnu.org; Fri, 30 Dec 2011 20:01:00 -0500
Message-ID: <DA0F642520424EBB9E84998F50E5FDBA@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <5DE30B86318741F8B2D56EA407C5A8DB@FSCPC><4EFE4483.1010707@weilnetz.de><1325289569$267@local>
	<CAFEAcA9f4Bb=UOs3+=S=aZxaUN+Pb1MUROhSZCF+Sm1uTuyStw@mail.gmail.com>
In-Reply-To: <CAFEAcA9f4Bb=UOs3+=S=aZxaUN+Pb1MUROhSZCF+Sm1uTuyStw@mail.gmail.com>
Date: Sat, 31 Dec 2011 02:00:09 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="utf-8"; reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Subject: [PATCH] Make python mandatory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org

Peter Maydell wrote:
>On 30 December 2011 23:59, Sebastian Herbszt <herbszt@gmx.de> wrote:
>> Make python mandatory.
>>
>> +if has $python; then
>> + :
>> +else
>> + echo "Python not found. Use --python=/path/to/python"
>> + exit 1
>> fi
>>
>> if test -z "$target_list" ; then
>
> I know you've just removed the outer condition here, but
> while we're fiddling with it, wouldn't
>    if ! has "$python"; then
>        echo "Python not found etc"
>    fi
>
> be better?
> 
> -- PMM

I just restored it to the state it was before commit "guest agent: add --enable-guest-agent config option".
This check was added in commit "Let users select their pythons".

Sebastian