From: Ani Sinha <anisinha@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Philippe Mathieu-Daude <philmd@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local
Date: Fri, 29 Sep 2023 13:38:47 +0530 [thread overview]
Message-ID: <DA7D0A58-0B6B-4AFB-908A-F60EE2B7CC41@redhat.com> (raw)
In-Reply-To: <874jjdflvg.fsf@pond.sub.org>
> On 29-Sep-2023, at 1:32 PM, Markus Armbruster <armbru@redhat.com> wrote:
>
> Ani Sinha <anisinha@redhat.com> writes:
>
>>> On 29-Sep-2023, at 11:43 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>>
>>> Ani Sinha <anisinha@redhat.com> writes:
>>>
>>>>> On 29-Sep-2023, at 11:17 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>>>>
>>>>> Ani Sinha <anisinha@redhat.com> writes:
>>>>>
>>>>>> Code changes in acpi that addresses all compiler complaints coming from enabling
>>>>>> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing
>>>>>> other local variables or parameters. These makes the code confusing and/or adds
>>>>>> bugs that are difficult to catch.
>>>>>>
>>>>>> The code is tested to build with and without the flag turned on.
>>>>>>
>>>>>> CC: Markus Armbruster <armbru@redhat.com>
>>>>>> CC: Philippe Mathieu-Daude <philmd@linaro.org>
>>>>>> CC: mst@redhat.com
>>>>>> CC: imammedo@redhat.com
>>>>>> Message-Id: <87r0mqlf9x.fsf@pond.sub.org>
>>>>>
>>>>> This is my "Help wanted for enabling -Wshadow=local" post.
>>>>
>>>> Yes indeed. I wanted to refer to that thread for context in the commit log.
>>>
>>> I appreciate your diligence. We just don't have an established tag
>>> convention for "see also" references to e-mail. I could append
>>>
>>> See also
>>>
>>> Subject: Help wanted for enabling -Wshadow=local
>>> Message-Id: <87r0mqlf9x.fsf@pond.sub.org>
>>> https://lore.kernel.org/qemu-devel/87r0mqlf9x.fsf@pond.sub.org
>>>
>>> to your first paragraph. Want me to?
>>
>> Sure, if that is ok.
>
> Done!
Your shadow-next has no changes. Have you not pushed to that branch?
next prev parent reply other threads:[~2023-09-29 8:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 12:42 [PATCH] hw/acpi: changes towards enabling -Wshadow=local Ani Sinha
2023-09-22 16:03 ` Michael S. Tsirkin
2023-09-29 5:47 ` Markus Armbruster
2023-09-29 5:54 ` Ani Sinha
2023-09-29 6:13 ` Markus Armbruster
2023-09-29 6:15 ` Ani Sinha
2023-09-29 8:02 ` Markus Armbruster
2023-09-29 8:08 ` Ani Sinha [this message]
2023-09-29 8:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA7D0A58-0B6B-4AFB-908A-F60EE2B7CC41@redhat.com \
--to=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).