qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierre Riteau <Pierre.Riteau@irisa.fr>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support
Date: Tue, 24 Nov 2009 12:17:04 +0100	[thread overview]
Message-ID: <DB148A1F-377F-41EF-B10F-693E628837FB@irisa.fr> (raw)
In-Reply-To: <1259058521.8935.21.camel@blaa>

On 24 nov. 2009, at 11:28, Mark McLoughlin wrote:

> On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
>> vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
>> the kernel doesn't support IFF_VNET_HDR.
>> 
>> Signed-off-by: Pierre Riteau <Pierre.Riteau@irisa.fr>
> 
> Thanks Pierre, I see why this is needed now
> 
> Acked-by: Mark McLoughlin <markmc@redhat.com>
> 
> Cheers,
> Mark.


Thanks for your rapid answer!

BTW, every time I run qemu I see this error message:

    TUNSETOFFLOAD ioctl() failed: Invalid argument

It is caused by the piece of code at the end of net/tap-linux.c:

    if (ioctl(fd, TUNSETOFFLOAD, offload) != 0) {
        offload &= ~TUN_F_UFO;
        if (ioctl(fd, TUNSETOFFLOAD, offload) != 0) {
            fprintf(stderr, "TUNSETOFFLOAD ioctl() failed: %s\n",
                    strerror(errno));
        }
    }

Isn't there a way to detect whether the kernel supports the TUNSETOFFLOAD ioctl at all?

-- 
Pierre Riteau -- http://perso.univ-rennes1.fr/pierre.riteau/

  reply	other threads:[~2009-11-24 11:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24  9:06 [Qemu-devel] [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support Pierre Riteau
2009-11-24 10:05 ` [Qemu-devel] [PATCH] net: initialize vnet_hdr in net_tap_init() Mark McLoughlin
2009-11-24 10:24   ` Pierre Riteau
2009-11-24 10:28 ` [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support Mark McLoughlin
2009-11-24 11:17   ` Pierre Riteau [this message]
2009-11-24 11:22     ` Mark McLoughlin
2009-11-24 21:27       ` Pierre Riteau
2009-11-25  8:55         ` Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB148A1F-377F-41EF-B10F-693E628837FB@irisa.fr \
    --to=pierre.riteau@irisa.fr \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).