From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCtOV-0001k8-Eb
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 06:17:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCtOQ-0001Yw-Hy
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 06:17:14 -0500
Received: from [199.232.76.173] (port=39203 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCtOQ-0001Yd-5j
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 06:17:10 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:39235)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <Pierre.Riteau@irisa.fr>)
	id 1NCtOP-0007oi-BE
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 06:17:09 -0500
Subject: Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels
	without IFF_VNET_HDR support
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Pierre Riteau <Pierre.Riteau@irisa.fr>
In-Reply-To: <1259058521.8935.21.camel@blaa>
Date: Tue, 24 Nov 2009 12:17:04 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <DB148A1F-377F-41EF-B10F-693E628837FB@irisa.fr>
References: <1259053593-15362-1-git-send-email-Pierre.Riteau@irisa.fr>
	<1259058521.8935.21.camel@blaa>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org

On 24 nov. 2009, at 11:28, Mark McLoughlin wrote:

> On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
>> vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
>> the kernel doesn't support IFF_VNET_HDR.
>>=20
>> Signed-off-by: Pierre Riteau <Pierre.Riteau@irisa.fr>
>=20
> Thanks Pierre, I see why this is needed now
>=20
> Acked-by: Mark McLoughlin <markmc@redhat.com>
>=20
> Cheers,
> Mark.


Thanks for your rapid answer!

BTW, every time I run qemu I see this error message:

    TUNSETOFFLOAD ioctl() failed: Invalid argument

It is caused by the piece of code at the end of net/tap-linux.c:

    if (ioctl(fd, TUNSETOFFLOAD, offload) !=3D 0) {
        offload &=3D ~TUN_F_UFO;
        if (ioctl(fd, TUNSETOFFLOAD, offload) !=3D 0) {
            fprintf(stderr, "TUNSETOFFLOAD ioctl() failed: %s\n",
                    strerror(errno));
        }
    }

Isn't there a way to detect whether the kernel supports the =
TUNSETOFFLOAD ioctl at all?

--=20
Pierre Riteau -- http://perso.univ-rennes1.fr/pierre.riteau/