From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcI3R-0005iV-5f for qemu-devel@nongnu.org; Wed, 16 Sep 2015 15:07:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcI3O-0000Wg-0E for qemu-devel@nongnu.org; Wed, 16 Sep 2015 15:07:41 -0400 Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:33755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcI3N-0000Vk-Qc for qemu-devel@nongnu.org; Wed, 16 Sep 2015 15:07:37 -0400 Received: by qgev79 with SMTP id v79so179959051qge.0 for ; Wed, 16 Sep 2015 12:07:35 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Programmingkid In-Reply-To: Date: Wed, 16 Sep 2015 15:07:33 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel qemu-devel On Sep 14, 2015, at 11:43 AM, Peter Maydell wrote: > On 11 September 2015 at 01:49, Programmingkid = wrote: >> Remove the open dialog code that runs when no arguments are supplied = with >> QEMU. >> Not everyone needs a hard drive or cdrom to boot their target. A user = might >> only >> need to use their target's bios to do work. With that said, this = patch >> removes >> the unneeded open dialog code. >>=20 >> Signed-off-by: John Arbuckle >=20 > I admit to not being much of a fan of this feature of the > Cocoa UI, but it has been in QEMU's OSX UI since 2005. > In particular, if you remove it then double-clicking to > start QEMU from the Finder won't do anything useful, and > you now have to start it from the command line. >=20 > I agree that it does somewhat assume the x86-centric > "just provide a disk image" semantics, but it's not clear > to me that the most appropriate way to deal with this is > to just rip the dialog box code out entirely. What does QEMU do when it is launched under Linux with no arguments = supplied? If you decide to keep the code, could it be fixed so that it compiles = under GCC 4.9?=