From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V6fJk-0007Zc-OK
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:20:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V6fJh-0005KM-SJ
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:20:44 -0400
Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:34577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V6fJh-0005K0-LL
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:20:41 -0400
Date: Tue, 06 Aug 2013 12:20:31 +0100
From: Alex Bligh <alex@alex.org.uk>
Message-ID: <DCF9C64E8389F862A0251C04@nimrod.local>
In-Reply-To: <20130806101017.GA7439@stefanha-thinkpad.redhat.com>
References: <714109BBB1F743A30290732C@nimrod.local>
	<1375639805-1943-1-git-send-email-alex@alex.org.uk>
	<1375639805-1943-7-git-send-email-alex@alex.org.uk>
	<20130806101017.GA7439@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Re: [Qemu-devel] [RFC] [PATCHv5 06/16] aio / timers: Untangle
 include files
Reply-To: Alex Bligh <alex@alex.org.uk>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Alex Bligh <alex@alex.org.uk>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Stefan,

--On 6 August 2013 12:10:17 +0200 Stefan Hajnoczi <stefanha@gmail.com> 
wrote:

> Fails to build ui/vnc-auth-sasl.c
>
> Please make sure that your ./configure output shows most optional
> dependencies are available (you need to install development packages for
> these libraries).  Otherwise you will not see build breakage.

Thanks. It will no doubt need a:

#include "qemu/main-loop.h"

I'll need to find something to build all this on a little more powerful
than the puny VM on my laptop.

Is this untangling include files approach a good one? Most of the functions
that these things needed appeared to have little to do with main-loop
per se. (though they are in main-loop.c).

-- 
Alex Bligh