From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHHnr-0000i4-Gk
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 09:09:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHHnn-0000fN-Lq
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 09:09:35 -0500
Received: from [199.232.76.173] (port=60286 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHHnn-0000f2-Bb
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 09:09:31 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:55375)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <andreas.faerber@web.de>) id 1NHHnm-0007bZ-S2
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 09:09:31 -0500
Message-Id: <DD6EC53D-EC23-4B5E-97ED-BFEE3D382E4A@web.de>
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
In-Reply-To: <CB324D95-CF08-4399-A5CD-1E8F138FA12C@kronenberg.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Date: Sun, 6 Dec 2009 15:09:06 +0100
References: <Pine.LNX.4.64.0912060927500.5876@linmac.oyster.ru>
	<1260104426-725-1-git-send-email-andreas.faerber@web.de>
	<1260104426-725-2-git-send-email-andreas.faerber@web.de>
	<CB324D95-CF08-4399-A5CD-1E8F138FA12C@kronenberg.org>
Sender: andreas.faerber@web.de
Subject: [Qemu-devel] Re: [PATCH v2 2/3] Cocoa: ppc64 host support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mike Kronenberg <mike.kronenberg@kronenberg.org>
Cc: Alexander Graf <alex@csgraf.de>, QEMU Developers <qemu-devel@nongnu.org>


Am 06.12.2009 um 14:41 schrieb Mike Kronenberg:

> On 06.12.2009, at 14:00, Andreas Faerber wrote:
>
>> -            int rectCount;
>> +            NSInteger rectCount;
>
> I know that this is endorsed by apple since 10.5 but NSInteger will  
> break compiling on Tiger and older.

You appear to be right there... no trace of it in 10.4u SDK.

> Int on the other hand is only throwing a warning on Leopard if I'm  
> not mistaken.

On Leopard ppc it just warns and works because NSInteger == int.
On Leopard ppc64 it warns and fails at runtime because NSInteger != int.

> Especially with qemu, one has to have an eye on the type...  
> NSInteger can be an int or a long, depending on the host...
>
> #if __LP64__ || NS_BUILD_32_LIKE_64
> 	typedef long NSInteger;
> 	typedef unsigned long NSUInteger;
> #else
> 	typedef int NSInteger;
> 	typedef unsigned int NSUInteger;
> #endif

Right, so we do need NSInteger - I'll add a version check. Thanks for  
the feedback!

Andreas