qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Chad Jablonski" <chad@jablonski.xyz>
To: "BALATON Zoltan" <balaton@eik.bme.hu>,
	"Chad Jablonski" <chad@jablonski.xyz>
Cc: <qemu-devel@nongnu.org>, <kraxel@redhat.com>,
	<marcandre.lureau@redhat.com>
Subject: Re: [PATCH v3 1/1] ati-vga: Fix framebuffer mapping by using hardware-correct aperture sizes
Date: Fri, 17 Oct 2025 11:50:09 -0400	[thread overview]
Message-ID: <DDKPSZZMSXAH.2OQFS388R366I@jablonski.xyz> (raw)
In-Reply-To: <29d6945e-4e55-4ded-a1a5-33e614a3145f@eik.bme.hu>

>
> So can't we just use here memory_region_size(&s->linear_aper) / 2 like for 
> CONFIG_REG_APER_SIZE? With that
>

Yep! That makes a lot more sense. Sending v4.

> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> Thank you for testing and finding out all this.
>

Thank you for taking the time to review!

- Chad


      reply	other threads:[~2025-10-17 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 14:50 [PATCH v3 0/1] ati-vga: Fix framebuffer mapping by using hardware-correct aperture sizes Chad Jablonski
2025-10-17 14:50 ` [PATCH v3 1/1] " Chad Jablonski
2025-10-17 15:09   ` BALATON Zoltan
2025-10-17 15:50     ` Chad Jablonski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DDKPSZZMSXAH.2OQFS388R366I@jablonski.xyz \
    --to=chad@jablonski.xyz \
    --cc=balaton@eik.bme.hu \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).