From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E343CC31E47 for ; Sat, 15 Jun 2019 06:17:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC0452184C for ; Sat, 15 Jun 2019 06:17:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="al7gbUJI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC0452184C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc20g-00010e-Li for qemu-devel@archiver.kernel.org; Sat, 15 Jun 2019 02:17:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59929) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc1zS-0008QY-T4 for qemu-devel@nongnu.org; Sat, 15 Jun 2019 02:16:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hc1zR-0002CO-DY for qemu-devel@nongnu.org; Sat, 15 Jun 2019 02:16:38 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:50358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hc1zP-0001sl-7i; Sat, 15 Jun 2019 02:16:37 -0400 Received: by mail-wm1-x341.google.com with SMTP id c66so4349749wmf.0; Fri, 14 Jun 2019 23:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:cc:from:message-id; bh=DAxc5dy0+uGy/JP2OU5SIVh5tvhIxU8HqRH7eFKD2F8=; b=al7gbUJIjpcVYXPD+EEyM/rHZ8wIgZZffKlBetKAvVOxLxFxO9xS4EEFql8+sOd0is QmMsosot4g4olenik2BQb4zhDEt4XysDZvi9Y//AXcciSwl4CxzOAOqsNwylBEuqGJv4 ZmGd9p09wIw5b6oZ+OVtUE0TCaXjXsoFXludVBtkkmvWn9oCKPDe2+Hstj6V6b1aqtW7 XeJkuyBR4C3eHoHJEcH52GFhG8zLiYdZuOOOe10/lT3Fl4AN4TOF7oDTkK6d5uWILLjU OXNwMoL8eEaBMY8/0oTscyYTK5FaxKLfpruF+8UGZNJescGQ5brzDWVVN6dxV9vbMSDy PYIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:subject:to:cc:from :message-id; bh=DAxc5dy0+uGy/JP2OU5SIVh5tvhIxU8HqRH7eFKD2F8=; b=VLshLYxU61vDuLTBEBb28F8ugz6sm/9QsGV/PdZWc1J608Z8Km8G5ANlDsTJK0mk13 e0bXq8mcY1gcZaYllQqaEW+wYpiptzgyQrcUZNONyImZ9gNXAudUQ3DXRJeLNbcu+lPj Puo21AD8ZUiOF8OzNA/DIflMA0M98BaUWJYXwRqR+M5tku4rm4FHTt4MLFVPaxsQTQdO xlPtBC77hzHOqEg+Ej0g/zjoNocyZofQ1NkgiskBme07GP2ONmoZZCuasLY24xf4OJvI 6PpKKfEh24pIszAM6rDhvrAtbOavzG61uMAJH6ruTfkO+6Y+kgNqIxEyH7WYMH0/XK+e XE9Q== X-Gm-Message-State: APjAAAV7z/Cg2GD52n3mgZk6JfAA/c3LcieEEKBD5AgXGprwszP+SVO9 7XXo+23jvhiQ+HPO0skrCAM= X-Google-Smtp-Source: APXvYqwX3/jfGL0/JUN7hqDRdCrzE3GHGUL66OJbrKqg6F7zvmCFH7Vnpx3WApFSNxl8CnwbhtKHaw== X-Received: by 2002:a1c:1f06:: with SMTP id f6mr10925560wmf.60.1560579371253; Fri, 14 Jun 2019 23:16:11 -0700 (PDT) Received: from [192.168.1.10] ([141.226.31.91]) by smtp.gmail.com with ESMTPSA id g131sm3598355wmf.37.2019.06.14.23.16.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 23:16:10 -0700 (PDT) Date: Sat, 15 Jun 2019 09:16:06 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <20190615051559.13767-1-rfried.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-devel@nongnu.org, qemu-trivial@nongnu.org From: Ramon Fried Message-ID: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: Re: [Qemu-devel] [PATCH v3] net: cadence_gem: fix compilation error when debug is on X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Alistair Francis , "open list:Xilinx Zynq" , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On June 15, 2019 8:38:35 AM GMT+03:00, "Philippe Mathieu-Daud=C3=A9" wrote: >Hi Ramon, > >On 6/15/19 7:15 AM, Ramon Fried wrote: >> defining CADENCE_GEM_ERR_DEBUG causes compilation >> errors, fix that=2E >>=20 >> Signed-off-by: Ramon Fried >> --- >> v2: change %lx to HWADDR_PRIx and %lx to %zdx >> v3: change %zdx to %zx >>=20 >> hw/net/cadence_gem=2Ec | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >>=20 >> diff --git a/hw/net/cadence_gem=2Ec b/hw/net/cadence_gem=2Ec >> index 7f63411430=2E=2Eecee22525c 100644 >> --- a/hw/net/cadence_gem=2Ec >> +++ b/hw/net/cadence_gem=2Ec >> @@ -982,8 +982,8 @@ static ssize_t gem_receive(NetClientState *nc, >const uint8_t *buf, size_t size) >> return -1; >> } >> =20 >> - DB_PRINT("copy %d bytes to 0x%x\n", MIN(bytes_to_copy, >rxbufsize), >> - rx_desc_get_buffer(s->rx_desc[q])); >> + DB_PRINT("copy %d bytes to 0x%" HWADDR_PRIx "\n", >MIN(bytes_to_copy, rxbufsize), >> + rx_desc_get_buffer(s, s->rx_desc[q])); >> =20 >> /* Copy packet data to emulated DMA buffer */ >> address_space_write(&s->dma_as, rx_desc_get_buffer(s, >s->rx_desc[q]) + >> @@ -1156,7 +1156,7 @@ static void gem_transmit(CadenceGEMState *s) >> if (tx_desc_get_length(desc) > sizeof(tx_packet) - >> (p - tx_packet)) { >> DB_PRINT("TX descriptor @ 0x%x too large: size 0x%x >space " \ >> - "0x%x\n", (unsigned)packet_desc_addr, >> + "0x%zx\n", (unsigned)packet_desc_addr, >> (unsigned)tx_desc_get_length(desc), >> sizeof(tx_packet) - (p - tx_packet)); >> break; >>=20 > >I still get an error when trying to build on 32bit host with >CADENCE_GEM_ERR_DEBUG enabled (pre-existing to your patch): > > CC hw/net/cadence_gem=2Eo >=2E/hw/net/cadence_gem=2Ec: In function 'gem_receive': >=2E/hw/net/cadence_gem=2Ec:973:14: error: format '%ld' expects argument o= f >type 'long int', but argument 4 has type 'size_t {aka unsigned int}' >[-Werror=3Dformat=3D] > DB_PRINT("config bufsize: %d packet size: %ld\n", rxbufsize, size); > ^ >=2E/hw/net/cadence_gem=2Ec:38:24: note: in definition of macro 'DB_PRINT' > fprintf(stderr, ## __VA_ARGS__); \ > ^ >cc1: all warnings being treated as errors >=2E/rules=2Emak:69: recipe for target 'hw/net/cadence_gem=2Eo' failed >make: *** [hw/net/cadence_gem=2Eo] Error 1 > >However the 64bit host is indeed fixed, so I'm fine with your patch: >Reviewed-by: Philippe Mathieu-Daud=C3=A9 >Tested-by: Philippe Mathieu-Daud=C3=A9 > >Regards, > >Phil=2E Thanks!=20 --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E