[Qemu-devel] qemu/hw usb-uhci.c

[Qemu-devel] qemu/hw usb-uhci.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/11/05 17:22:48

Modified files:
	hw             : usb-uhci.c 

Log message:
	same PCI parameters as PIIX3

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.1&tr2=1.2&r1=text&r2=text

[Qemu-devel] qemu/hw usb-uhci.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/11/19 17:43:37

Modified files:
	hw             : usb-uhci.c 

Log message:
	USB reset typo (Lonnie Mendez)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.3&tr2=1.4&r1=text&r2=text

[Qemu-devel] qemu/hw usb-uhci.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Paul Brook <pbrook@savannah.gnu.org>	06/03/11 21:46:12

Modified files:
	hw             : usb-uhci.c 

Log message:
	Add missing break statement.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.5&tr2=1.6&r1=text&r2=text

[Qemu-devel] qemu/hw usb-uhci.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/04/24 21:38:50

Modified files:
	hw             : usb-uhci.c 

Log message:
	HCHALTED status bit handling (Lonnie Mendez)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text

Re: [Qemu-devel] qemu/hw usb-uhci.c

[nix.wie.weg]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hello Fabrice,

This patch introduces an already fixed bug with linux guest os. The
message is: "controller still running". The attached patch fixes this
problem.
Believe me it would save both of us a lot of time, if you would simply
add the large usb patch.

With kind regards,
Tino H. Seifert

Fabrice Bellard wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Branch: 	
> Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/04/24 21:38:50
>
> Modified files:
> 	hw             : usb-uhci.c 
>
> Log message:
> 	HCHALTED status bit handling (Lonnie Mendez)
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>
>   

[-- Attachment #2: usb.patch --]
[-- Type: text/x-patch, Size: 665 bytes --]

Index: hw/usb-uhci.c
===================================================================
RCS file: /sources/qemu/qemu/hw/usb-uhci.c,v
retrieving revision 1.7
diff -u -r1.7 usb-uhci.c
--- hw/usb-uhci.c	24 Apr 2006 21:38:50 -0000	1.7
+++ hw/usb-uhci.c	24 Apr 2006 23:00:49 -0000
@@ -175,7 +175,7 @@
             /* start frame processing */
             qemu_mod_timer(s->frame_timer, qemu_get_clock(vm_clock));
             s->status &= ~UHCI_STS_HCHALTED;
-        } else if (!(val & UHCI_CMD_RS) && !(s->cmd & UHCI_CMD_RS)) {
+        } else if (!(val & UHCI_CMD_RS)) {
             s->status |= UHCI_STS_HCHALTED;
         }
         if (val & UHCI_CMD_GRESET) {

Re: [Qemu-devel] qemu/hw usb-uhci.c

[Lonnie Mendez]

nix.wie.weg@gmx.de wrote:

>Hello Fabrice,
>
>This patch introduces an already fixed bug with linux guest os. The
>message is: "controller still running". The attached patch fixes this
>problem.
>  
>
   To expand on this, I saw windows checking the status register several 
times to look for hchalt once R/S bit was written 0.  However, Linux 
guest hcd only checks the status register once before giving up.  So the 
much simpler patch here works in both cases.  However, it also means we 
can't properly indicate when the frame has really stopped and the host 
controller halted.  This isn't something that shows up with the code in 
CVS because the hub is always attached and thus the linux hcd doesn't 
try to suspend the bus (Windows XP will do this and there is a patch 
I'll try to submit later on this week - very busy).

[Qemu-devel] qemu/hw usb-uhci.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/04/25 21:01:20

Modified files:
	hw             : usb-uhci.c 

Log message:
	fix for HCHALTED status bit

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.7&tr2=1.8&r1=text&r2=text

Re: [Qemu-devel] qemu/hw usb-uhci.c

[Fabrice Bellard]

OK for the UHCI fix.

I need more time to accept your big patch. I think it would have been 
better to separate the bug fixes, the new USB host drivers and the API 
changes. I would have included the first two without problem, but I need 
to better understand your API changes before commiting them.

Regards,

Fabrice.

nix.wie.weg@gmx.de wrote:
> Hello Fabrice,
> 
> This patch introduces an already fixed bug with linux guest os. The
> message is: "controller still running". The attached patch fixes this
> problem.
> Believe me it would save both of us a lot of time, if you would simply
> add the large usb patch.
> 
> With kind regards,
> Tino H. Seifert
> 
> Fabrice Bellard wrote:
> 
>>CVSROOT:	/sources/qemu
>>Module name:	qemu
>>Branch: 	
>>Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/04/24 21:38:50
>>
>>Modified files:
>>	hw             : usb-uhci.c 
>>
>>Log message:
>>	HCHALTED status bit handling (Lonnie Mendez)
>>
>>CVSWeb URLs:
>>http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text
>>
>>
>>_______________________________________________
>>Qemu-devel mailing list
>>Qemu-devel@nongnu.org
>>http://lists.nongnu.org/mailman/listinfo/qemu-devel
>>
>>
>>  
>>
>>
>>------------------------------------------------------------------------
>>
>>Index: hw/usb-uhci.c
>>===================================================================
>>RCS file: /sources/qemu/qemu/hw/usb-uhci.c,v
>>retrieving revision 1.7
>>diff -u -r1.7 usb-uhci.c
>>--- hw/usb-uhci.c	24 Apr 2006 21:38:50 -0000	1.7
>>+++ hw/usb-uhci.c	24 Apr 2006 23:00:49 -0000
>>@@ -175,7 +175,7 @@
>>             /* start frame processing */
>>             qemu_mod_timer(s->frame_timer, qemu_get_clock(vm_clock));
>>             s->status &= ~UHCI_STS_HCHALTED;
>>-        } else if (!(val & UHCI_CMD_RS) && !(s->cmd & UHCI_CMD_RS)) {
>>+        } else if (!(val & UHCI_CMD_RS)) {
>>             s->status |= UHCI_STS_HCHALTED;
>>         }
>>         if (val & UHCI_CMD_GRESET) {
>>
>>
>>------------------------------------------------------------------------
>>
>>_______________________________________________
>>Qemu-devel mailing list
>>Qemu-devel@nongnu.org
>>http://lists.nongnu.org/mailman/listinfo/qemu-devel

Re: [Qemu-devel] qemu/hw usb-uhci.c

[Johannes Schindelin]

Hi,

On Tue, 25 Apr 2006, Fabrice Bellard wrote:

> I need more time to accept your big patch. I think it would have been better
> to separate the bug fixes, the new USB host drivers and the API changes. I
> would have included the first two without problem, but I need to better
> understand your API changes before commiting them.

Note that it is common to feed the maintainer small patches in Open Source 
projects.

Just look at Linux. If you tried to get such a huge patch past a 
maintainer, you would utterly fail.

And rightly so. A maintainer is supposed to understand exactly what the 
changes are about.

Further, if you split the patch into nice little pieces, not only are you 
and everyone else more aware of what exactly you did, but it is way easier 
to spot errors or mistakes.

Hth,
Dscho

[Qemu-devel] qemu/hw usb-uhci.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/01/17 23:08:17

Modified files:
	hw             : usb-uhci.c 

Log message:
	Fix USB buffer size, by Herbert Xu.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/usb-uhci.c?cvsroot=qemu&r1=1.12&r2=1.13

[Qemu-devel] qemu/hw usb-uhci.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/02/22 20:21:33

Modified files:
	hw             : usb-uhci.c 

Log message:
	Basic USB device resume (root hub only), by Lonnie Mendez.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/usb-uhci.c?cvsroot=qemu&r1=1.13&r2=1.14

[Qemu-devel] qemu/hw usb-uhci.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	07/11/11 19:46:37

Modified files:
	hw             : usb-uhci.c 

Log message:
	removed unused code

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/usb-uhci.c?cvsroot=qemu&r1=1.20&r2=1.21