[Qemu-devel] qemu/hw piix_pci.c

[Qemu-devel] qemu/hw piix_pci.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/09/24 18:49:13

Modified files:
	hw             : piix_pci.c 

Log message:
	moved PCI init to BIOS - added ISA memory mapping registers and SMM support

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.4&r2=1.5

[Qemu-devel] qemu/hw piix_pci.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/09/24 19:31:43

Modified files:
	hw             : piix_pci.c 

Log message:
	implement i440 instead of i450 ISA memory mappings to be compatible with Bochs

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.5&r2=1.6

[Qemu-devel] qemu/hw piix_pci.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/01/15 17:08:08

Modified files:
	hw             : piix_pci.c 

Log message:
	PIIX4 support, by Aurelien Jarno.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.7&r2=1.8

[Qemu-devel] qemu/hw piix_pci.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/10/20 20:36:52

Modified files:
	hw             : piix_pci.c 

Log message:
	Enable ACPI interrupts, by Igor Lvovsky.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.11&r2=1.12

Re: [Qemu-devel] qemu/hw piix_pci.c

[Avi Kivity]

Thiemo Seufer wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Thiemo Seufer <ths>	07/10/20 20:36:52
>
> Modified files:
> 	hw             : piix_pci.c 
>
> Log message:
> 	Enable ACPI interrupts, by Igor Lvovsky.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.11&r2=1.12
>
>   

IMO this is a bug.  The patch enables the ACPI PCI interrupt every time 
it is asserted.  If this is really needed, this implies that the guest 
OS detects some sort of inconsistency and keeps turning the ACPI 
interrupt off.

The bug should be addressed instead of worked-around in this way.


-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] qemu/hw piix_pci.c

[Thiemo Seufer]

Avi Kivity wrote:
>> Modified files:
>> 	hw             : piix_pci.c 
>> Log message:
>> 	Enable ACPI interrupts, by Igor Lvovsky.
>>
>> CVSWeb URLs:
>> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.11&r2=1.12
>>
>>   
>
> IMO this is a bug.  The patch enables the ACPI PCI interrupt every time it 
> is asserted.  If this is really needed, this implies that the guest OS 
> detects some sort of inconsistency and keeps turning the ACPI interrupt 
> off.
>
> The bug should be addressed instead of worked-around in this way.

Igor, could you clarify what happens there?


Thiemo

RE: [Qemu-devel] qemu/hw piix_pci.c

[Igor Lvovsky]

> -----Original Message-----
> From: Thiemo Seufer [mailto:ths@networkno.de]
> Sent: Monday, October 22, 2007 12:16 AM
> To: Avi Kivity
> Cc: qemu-devel@nongnu.org; Igor Lvovsky
> Subject: Re: [Qemu-devel] qemu/hw piix_pci.c
> 
> Avi Kivity wrote:
> >> Modified files:
> >> 	hw             : piix_pci.c
> >> Log message:
> >> 	Enable ACPI interrupts, by Igor Lvovsky.
> >>
> >> CVSWeb URLs:
> >>
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.1
> 1&r2=1.12
> >>
> >>
> >
> > IMO this is a bug.  The patch enables the ACPI PCI interrupt every time
> it
> > is asserted.  If this is really needed, this implies that the guest OS
> > detects some sort of inconsistency and keeps turning the ACPI interrupt
> > off.
> >
> > The bug should be addressed instead of worked-around in this way.
> 
> Igor, could you clarify what happens there?

[Igor Lvovsky] Yes sure. I rechecked it and it seems like reasonable conclusion.
As I mentioned before, enable bit of PIRQRCA should be 0, but somehow
Windows set it all the time. One of the reasons can be some sort 
of inconsistency.
My last patch can be temporary workaround and now we can get the ACPI 
interrupts without disrupt anything  else, but I'll try to find full solution for this issue.
	Igor
 



> 
> 
> Thiemo

Re: [Qemu-devel] qemu/hw piix_pci.c

[Michael Hanselmann]

On Mon, Oct 22, 2007 at 12:52:30AM -0700, Igor Lvovsky wrote:
> My last patch can be temporary workaround and now we can get the ACPI 
> interrupts without disrupt anything  else, but I'll try to find full
> solution for this issue.

Interestingly, Linux doesn't receive any interrupts from ACPI, too.
There must be something wrong with the hardware emulation.

At [1] you can find a question I sent to this list, but didn't get a
response. Just yesterday I started working on it again and it still
doesn't work, even with your patch. Before I start going through all the
ACPI specs and the Linux driver's code, do you have an idea what might
be the problem?

Thanks,
Michael

[1] http://lists.gnu.org/archive/html/qemu-devel/2007-06/msg00450.html

-- 
http://hansmi.ch/

RE: [Qemu-devel] qemu/hw piix_pci.c

[Igor Lvovsky]

> -----Original Message-----
> From: qemu-devel-bounces+igor.lvovsky=qumranet.com@nongnu.org
> [mailto:qemu-devel-bounces+igor.lvovsky=qumranet.com@nongnu.org] On Behalf
> Of Michael Hanselmann
> Sent: Monday, October 22, 2007 10:27 AM
> To: qemu-devel@nongnu.org
> Cc: Avi Kivity
> Subject: Re: [Qemu-devel] qemu/hw piix_pci.c
> 
> On Mon, Oct 22, 2007 at 12:52:30AM -0700, Igor Lvovsky wrote:
> > My last patch can be temporary workaround and now we can get the ACPI
> > interrupts without disrupt anything  else, but I'll try to find full
> > solution for this issue.
> 
> Interestingly, Linux doesn't receive any interrupts from ACPI, too.
> There must be something wrong with the hardware emulation.

[Igor Lvovsky] Probably, I will go over the spec again.

> 
> At [1] you can find a question I sent to this list, but didn't get a
> response. Just yesterday I started working on it again and it still
> doesn't work, even with your patch. 

[Igor Lvovsky] My patch fixes it for windows guest. I tried it for LID open/close events on my laptop. According to the spec OS should care these events through ACPI.
Now I have it works on windows guests via ACPI events, but on Linux guest it 
work without ACPI (weird).


Before I start going through all the
> ACPI specs and the Linux driver's code, do you have an idea what might
> be the problem?

[Igor Lvovsky] Not yet, but I'll inform you if I'll find something

> 
> Thanks,
> Michael
> 
> [1] http://lists.gnu.org/archive/html/qemu-devel/2007-06/msg00450.html
> 
> --
> http://hansmi.ch/
> 

[Qemu-devel] qemu/hw piix_pci.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/12/09 23:02:39

Modified files:
	hw             : piix_pci.c 

Log message:
	Remove leftover support for 82371FB (Step A1), by Carlo Marcelo Arenas
	Belon.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.14&r2=1.15

[Qemu-devel] qemu/hw piix_pci.c

[Aurelien Jarno]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Aurelien Jarno <aurel32>	08/03/28 22:28:46

Modified files:
	hw             : piix_pci.c 

Log message:
	Add missing initial values for PIIX3 function 0 (PIRQRC)
	
	(Sebastian Herbszt)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.17&r2=1.18