* [Qemu-devel] qemu vl.h hw/pckbd.c @ 2007-04-16 17:20 Thiemo Seufer 2007-04-16 17:36 ` Jocelyn Mayer 0 siblings, 1 reply; 2+ messages in thread From: Thiemo Seufer @ 2007-04-16 17:20 UTC (permalink / raw) To: qemu-devel CVSROOT: /sources/qemu Module name: qemu Changes by: Thiemo Seufer <ths> 07/04/16 17:20:48 Modified files: . : vl.h hw : pckbd.c Log message: Memory-mapped interface for PS/2 controller, by Herve Poussineau. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/vl.h?cvsroot=qemu&r1=1.210&r2=1.211 http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pckbd.c?cvsroot=qemu&r1=1.18&r2=1.19 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] qemu vl.h hw/pckbd.c 2007-04-16 17:20 [Qemu-devel] qemu vl.h hw/pckbd.c Thiemo Seufer @ 2007-04-16 17:36 ` Jocelyn Mayer 0 siblings, 0 replies; 2+ messages in thread From: Jocelyn Mayer @ 2007-04-16 17:36 UTC (permalink / raw) To: qemu-devel On Mon, 2007-04-16 at 17:20 +0000, Thiemo Seufer wrote: > CVSROOT: /sources/qemu > Module name: qemu > Changes by: Thiemo Seufer <ths> 07/04/16 17:20:48 > > Modified files: > . : vl.h > hw : pckbd.c > > Log message: > Memory-mapped interface for PS/2 controller, by Herve Poussineau. > > CVSWeb URLs: > http://cvs.savannah.gnu.org/viewcvs/qemu/vl.h?cvsroot=qemu&r1=1.210&r2=1.211 > http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pckbd.c?cvsroot=qemu&r1=1.18&r2=1.19 Hi, This patch is incorrect: - it does make use of the it_shift parameter - it does not properly handle word and long accesses. The patch for the RTC is also incorrect: - it does not have a it_shift parameter - it does not handle the target endianness. I've got a correct patch for the memory mapped keyboard, as used on some PowerPC boards. I'll commit it soon. Please take a look to fix the RTC issues. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-16 17:41 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-04-16 17:20 [Qemu-devel] qemu vl.h hw/pckbd.c Thiemo Seufer 2007-04-16 17:36 ` Jocelyn Mayer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).