* [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
@ 2007-09-16 21:59 Thiemo Seufer
0 siblings, 0 replies; 7+ messages in thread
From: Thiemo Seufer @ 2007-09-16 21:59 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Thiemo Seufer <ths> 07/09/16 21:59:02
Modified files:
. : block-qcow.c block-qcow2.c block-vmdk.c
block_int.h qemu-img.c qemu-img.texi
Log message:
vmdk compatibility level 6 images, by Soren Hansen.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow.c?cvsroot=qemu&r1=1.12&r2=1.13
http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow2.c?cvsroot=qemu&r1=1.7&r2=1.8
http://cvs.savannah.gnu.org/viewcvs/qemu/block-vmdk.c?cvsroot=qemu&r1=1.14&r2=1.15
http://cvs.savannah.gnu.org/viewcvs/qemu/block_int.h?cvsroot=qemu&r1=1.11&r2=1.12
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu-img.c?cvsroot=qemu&r1=1.19&r2=1.20
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu-img.texi?cvsroot=qemu&r1=1.5&r2=1.6
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
@ 2008-03-11 17:17 Aurelien Jarno
2008-03-11 17:30 ` Fabrice Bellard
0 siblings, 1 reply; 7+ messages in thread
From: Aurelien Jarno @ 2008-03-11 17:17 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Aurelien Jarno <aurel32> 08/03/11 17:17:59
Modified files:
. : block-qcow.c block-qcow2.c block-vmdk.c block.c
block.h block_int.h
Log message:
Fix CVE-2008-0928 - insufficient block device address range checking
Qemu 0.9.1 and earlier does not perform range checks for block device
read or write requests, which allows guest host users with root
privileges to access arbitrary memory and escape the virtual machine.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow.c?cvsroot=qemu&r1=1.15&r2=1.16
http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow2.c?cvsroot=qemu&r1=1.10&r2=1.11
http://cvs.savannah.gnu.org/viewcvs/qemu/block-vmdk.c?cvsroot=qemu&r1=1.19&r2=1.20
http://cvs.savannah.gnu.org/viewcvs/qemu/block.c?cvsroot=qemu&r1=1.54&r2=1.55
http://cvs.savannah.gnu.org/viewcvs/qemu/block.h?cvsroot=qemu&r1=1.6&r2=1.7
http://cvs.savannah.gnu.org/viewcvs/qemu/block_int.h?cvsroot=qemu&r1=1.16&r2=1.17
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
2008-03-11 17:17 Aurelien Jarno
@ 2008-03-11 17:30 ` Fabrice Bellard
2008-03-11 22:23 ` Aurelien Jarno
0 siblings, 1 reply; 7+ messages in thread
From: Fabrice Bellard @ 2008-03-11 17:30 UTC (permalink / raw)
To: qemu-devel
IMHO it would be much simpler to do all the tests in the block format
handlers.
Fabrice.
Aurelien Jarno wrote:
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Aurelien Jarno <aurel32> 08/03/11 17:17:59
>
> Modified files:
> . : block-qcow.c block-qcow2.c block-vmdk.c block.c
> block.h block_int.h
>
> Log message:
> Fix CVE-2008-0928 - insufficient block device address range checking
>
> Qemu 0.9.1 and earlier does not perform range checks for block device
> read or write requests, which allows guest host users with root
> privileges to access arbitrary memory and escape the virtual machine.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow.c?cvsroot=qemu&r1=1.15&r2=1.16
> http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow2.c?cvsroot=qemu&r1=1.10&r2=1.11
> http://cvs.savannah.gnu.org/viewcvs/qemu/block-vmdk.c?cvsroot=qemu&r1=1.19&r2=1.20
> http://cvs.savannah.gnu.org/viewcvs/qemu/block.c?cvsroot=qemu&r1=1.54&r2=1.55
> http://cvs.savannah.gnu.org/viewcvs/qemu/block.h?cvsroot=qemu&r1=1.6&r2=1.7
> http://cvs.savannah.gnu.org/viewcvs/qemu/block_int.h?cvsroot=qemu&r1=1.16&r2=1.17
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
2008-03-11 17:30 ` Fabrice Bellard
@ 2008-03-11 22:23 ` Aurelien Jarno
2008-03-11 22:43 ` Fabrice Bellard
0 siblings, 1 reply; 7+ messages in thread
From: Aurelien Jarno @ 2008-03-11 22:23 UTC (permalink / raw)
To: qemu-devel
Fabrice Bellard a écrit :
> IMHO it would be much simpler to do all the tests in the block format
> handlers.
>
Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?
> Aurelien Jarno wrote:
>> CVSROOT: /sources/qemu
>> Module name: qemu
>> Changes by: Aurelien Jarno <aurel32> 08/03/11 17:17:59
>>
>> Modified files:
>> . : block-qcow.c block-qcow2.c block-vmdk.c block.c
>> block.h block_int.h
>> Log message:
>> Fix CVE-2008-0928 - insufficient block device address range checking
>>
>> Qemu 0.9.1 and earlier does not perform range checks for block device
>> read or write requests, which allows guest host users with root
>> privileges to access arbitrary memory and escape the virtual machine.
>>
>> CVSWeb URLs:
>> http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow.c?cvsroot=qemu&r1=1.15&r2=1.16
>>
>> http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow2.c?cvsroot=qemu&r1=1.10&r2=1.11
>>
>> http://cvs.savannah.gnu.org/viewcvs/qemu/block-vmdk.c?cvsroot=qemu&r1=1.19&r2=1.20
>>
>> http://cvs.savannah.gnu.org/viewcvs/qemu/block.c?cvsroot=qemu&r1=1.54&r2=1.55
>>
>> http://cvs.savannah.gnu.org/viewcvs/qemu/block.h?cvsroot=qemu&r1=1.6&r2=1.7
>>
>> http://cvs.savannah.gnu.org/viewcvs/qemu/block_int.h?cvsroot=qemu&r1=1.16&r2=1.17
>>
>>
>>
>>
>
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
2008-03-11 22:23 ` Aurelien Jarno
@ 2008-03-11 22:43 ` Fabrice Bellard
2008-03-11 23:15 ` Aurelien Jarno
0 siblings, 1 reply; 7+ messages in thread
From: Fabrice Bellard @ 2008-03-11 22:43 UTC (permalink / raw)
To: qemu-devel
Aurelien Jarno wrote:
> Fabrice Bellard a écrit :
>> IMHO it would be much simpler to do all the tests in the block format
>> handlers.
>>
>
> Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?
I suggest reverting the patch and writing correct tests in
block-{qcow,qcow2,vmdk}.c. BTW, bs->total_sectors is not a good
indicator of the device size in case of removable devices for example.
Fabrice.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
2008-03-11 22:43 ` Fabrice Bellard
@ 2008-03-11 23:15 ` Aurelien Jarno
0 siblings, 0 replies; 7+ messages in thread
From: Aurelien Jarno @ 2008-03-11 23:15 UTC (permalink / raw)
To: qemu-devel
On Tue, Mar 11, 2008 at 11:43:47PM +0100, Fabrice Bellard wrote:
> Aurelien Jarno wrote:
> > Fabrice Bellard a écrit :
> >> IMHO it would be much simpler to do all the tests in the block format
> >> handlers.
> >>
> >
> > Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?
>
> I suggest reverting the patch and writing correct tests in
> block-{qcow,qcow2,vmdk}.c. BTW, bs->total_sectors is not a good
> indicator of the device size in case of removable devices for example.
>
I see. I will work on writing a patch asap, probably tomorrow evening.
Aurelien
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
@ 2008-03-11 23:30 Aurelien Jarno
0 siblings, 0 replies; 7+ messages in thread
From: Aurelien Jarno @ 2008-03-11 23:30 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Aurelien Jarno <aurel32> 08/03/11 23:30:22
Modified files:
. : block-qcow.c block-qcow2.c block-vmdk.c block.c
block.h block_int.h
linux-user : syscall.c
Log message:
Revert fix for CVE-2008-0928. Will be fixed in a different way later.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow.c?cvsroot=qemu&r1=1.16&r2=1.17
http://cvs.savannah.gnu.org/viewcvs/qemu/block-qcow2.c?cvsroot=qemu&r1=1.11&r2=1.12
http://cvs.savannah.gnu.org/viewcvs/qemu/block-vmdk.c?cvsroot=qemu&r1=1.20&r2=1.21
http://cvs.savannah.gnu.org/viewcvs/qemu/block.c?cvsroot=qemu&r1=1.55&r2=1.56
http://cvs.savannah.gnu.org/viewcvs/qemu/block.h?cvsroot=qemu&r1=1.7&r2=1.8
http://cvs.savannah.gnu.org/viewcvs/qemu/block_int.h?cvsroot=qemu&r1=1.17&r2=1.18
http://cvs.savannah.gnu.org/viewcvs/qemu/linux-user/syscall.c?cvsroot=qemu&r1=1.164&r2=1.165
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-03-11 23:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-16 21:59 [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl Thiemo Seufer
-- strict thread matches above, loose matches on Subject: below --
2008-03-11 17:17 Aurelien Jarno
2008-03-11 17:30 ` Fabrice Bellard
2008-03-11 22:23 ` Aurelien Jarno
2008-03-11 22:43 ` Fabrice Bellard
2008-03-11 23:15 ` Aurelien Jarno
2008-03-11 23:30 Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).