qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrzej Zaborowski <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4261] Errors while registering ioports are not fatal (Glauber Costa).
Date: Sat, 26 Apr 2008 16:04:30 +0000	[thread overview]
Message-ID: <E1Jpmt4-0003iE-AX@cvs.savannah.gnu.org> (raw)

Revision: 4261
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4261
Author:   balrog
Date:     2008-04-26 16:04:29 +0000 (Sat, 26 Apr 2008)

Log Message:
-----------
Errors while registering ioports are not fatal (Glauber Costa).

Modified Paths:
--------------
    trunk/vl.c

Modified: trunk/vl.c
===================================================================
--- trunk/vl.c	2008-04-26 15:56:05 UTC (rev 4260)
+++ trunk/vl.c	2008-04-26 16:04:29 UTC (rev 4261)
@@ -324,13 +324,13 @@
     } else if (size == 4) {
         bsize = 2;
     } else {
-        hw_error("register_ioport_read: invalid size");
+        fprintf(stderr, "register_ioport_read: invalid size\n");
         return -1;
     }
     for(i = start; i < start + length; i += size) {
         ioport_read_table[bsize][i] = func;
         if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
-            hw_error("register_ioport_read: invalid opaque");
+            fprintf(stderr, "register_ioport_read: invalid opaque\n");
         ioport_opaque[i] = opaque;
     }
     return 0;
@@ -349,13 +349,15 @@
     } else if (size == 4) {
         bsize = 2;
     } else {
-        hw_error("register_ioport_write: invalid size");
+        fprintf(stderr, "register_ioport_write: invalid size\n");
         return -1;
     }
     for(i = start; i < start + length; i += size) {
         ioport_write_table[bsize][i] = func;
-        if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
-            hw_error("register_ioport_write: invalid opaque");
+        if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque) {
+            fprintf(stderr, "register_ioport_write: invalid opaque\n");
+            return -1;
+        }
         ioport_opaque[i] = opaque;
     }
     return 0;

             reply	other threads:[~2008-04-26 16:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 16:04 Andrzej Zaborowski [this message]
2008-04-26 19:26 ` [Qemu-devel] [4261] Errors while registering ioports are not fatal (Glauber Costa) Paul Brook
2008-04-26 19:36   ` Anthony Liguori
2008-04-26 19:57     ` Paul Brook
2008-04-26 20:33       ` Anthony Liguori
2008-04-26 20:45       ` Glauber Costa
2008-04-26 19:57   ` andrzej zaborowski
2008-04-26 20:08     ` Paul Brook
2008-04-26 20:38       ` Anthony Liguori
2008-04-26 20:54         ` Paul Brook
2008-04-26 21:09           ` Anthony Liguori
2008-04-26 21:29             ` Paul Brook
2008-04-26 20:39     ` Glauber Costa
2008-04-26 20:43     ` Anthony Liguori
2008-04-26 21:18       ` andrzej zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Jpmt4-0003iE-AX@cvs.savannah.gnu.org \
    --to=balrogg@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).