From: Andrzej Zaborowski <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4262] IO ports registration errors are fatal errors.
Date: Sat, 26 Apr 2008 21:11:23 +0000 [thread overview]
Message-ID: <E1Jprg3-0006Ma-Jc@cvs.savannah.gnu.org> (raw)
Revision: 4262
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4262
Author: balrog
Date: 2008-04-26 21:11:22 +0000 (Sat, 26 Apr 2008)
Log Message:
-----------
IO ports registration errors are fatal errors.
Revert previous change that shouldn't have gone in alone (or at all).
Modified Paths:
--------------
trunk/vl.c
Modified: trunk/vl.c
===================================================================
--- trunk/vl.c 2008-04-26 16:04:29 UTC (rev 4261)
+++ trunk/vl.c 2008-04-26 21:11:22 UTC (rev 4262)
@@ -324,13 +324,13 @@
} else if (size == 4) {
bsize = 2;
} else {
- fprintf(stderr, "register_ioport_read: invalid size\n");
+ hw_error("register_ioport_read: invalid size");
return -1;
}
for(i = start; i < start + length; i += size) {
ioport_read_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- fprintf(stderr, "register_ioport_read: invalid opaque\n");
+ hw_error("register_ioport_read: invalid opaque");
ioport_opaque[i] = opaque;
}
return 0;
@@ -349,15 +349,13 @@
} else if (size == 4) {
bsize = 2;
} else {
- fprintf(stderr, "register_ioport_write: invalid size\n");
+ hw_error("register_ioport_write: invalid size");
return -1;
}
for(i = start; i < start + length; i += size) {
ioport_write_table[bsize][i] = func;
- if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque) {
- fprintf(stderr, "register_ioport_write: invalid opaque\n");
- return -1;
- }
+ if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
+ hw_error("register_ioport_write: invalid opaque");
ioport_opaque[i] = opaque;
}
return 0;
reply other threads:[~2008-04-26 21:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Jprg3-0006Ma-Jc@cvs.savannah.gnu.org \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).