* [Qemu-devel] [4262] IO ports registration errors are fatal errors.
@ 2008-04-26 21:11 Andrzej Zaborowski
0 siblings, 0 replies; only message in thread
From: Andrzej Zaborowski @ 2008-04-26 21:11 UTC (permalink / raw)
To: qemu-devel
Revision: 4262
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4262
Author: balrog
Date: 2008-04-26 21:11:22 +0000 (Sat, 26 Apr 2008)
Log Message:
-----------
IO ports registration errors are fatal errors.
Revert previous change that shouldn't have gone in alone (or at all).
Modified Paths:
--------------
trunk/vl.c
Modified: trunk/vl.c
===================================================================
--- trunk/vl.c 2008-04-26 16:04:29 UTC (rev 4261)
+++ trunk/vl.c 2008-04-26 21:11:22 UTC (rev 4262)
@@ -324,13 +324,13 @@
} else if (size == 4) {
bsize = 2;
} else {
- fprintf(stderr, "register_ioport_read: invalid size\n");
+ hw_error("register_ioport_read: invalid size");
return -1;
}
for(i = start; i < start + length; i += size) {
ioport_read_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
- fprintf(stderr, "register_ioport_read: invalid opaque\n");
+ hw_error("register_ioport_read: invalid opaque");
ioport_opaque[i] = opaque;
}
return 0;
@@ -349,15 +349,13 @@
} else if (size == 4) {
bsize = 2;
} else {
- fprintf(stderr, "register_ioport_write: invalid size\n");
+ hw_error("register_ioport_write: invalid size");
return -1;
}
for(i = start; i < start + length; i += size) {
ioport_write_table[bsize][i] = func;
- if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque) {
- fprintf(stderr, "register_ioport_write: invalid opaque\n");
- return -1;
- }
+ if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
+ hw_error("register_ioport_write: invalid opaque");
ioport_opaque[i] = opaque;
}
return 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-26 21:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-26 21:11 [Qemu-devel] [4262] IO ports registration errors are fatal errors Andrzej Zaborowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).