From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4272] Fix a typo in cpu_physical_memory_rw()
Date: Sun, 27 Apr 2008 23:53:45 +0000 [thread overview]
Message-ID: <E1JqGgj-0000Ab-Vy@cvs.savannah.gnu.org> (raw)
Revision: 4272
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4272
Author: aurel32
Date: 2008-04-27 23:53:45 +0000 (Sun, 27 Apr 2008)
Log Message:
-----------
Fix a typo in cpu_physical_memory_rw()
(Samuel Thibault)
Modified Paths:
--------------
trunk/exec.c
Modified: trunk/exec.c
===================================================================
--- trunk/exec.c 2008-04-27 23:52:12 UTC (rev 4271)
+++ trunk/exec.c 2008-04-27 23:53:45 UTC (rev 4272)
@@ -2544,20 +2544,20 @@
if (!(flags & PAGE_WRITE))
return;
/* XXX: this code should not depend on lock_user */
- if (!(p = lock_user(VERIFY_WRITE, addr, len, 0)))
+ if (!(p = lock_user(VERIFY_WRITE, addr, l, 0)))
/* FIXME - should this return an error rather than just fail? */
return;
- memcpy(p, buf, len);
- unlock_user(p, addr, len);
+ memcpy(p, buf, l);
+ unlock_user(p, addr, l);
} else {
if (!(flags & PAGE_READ))
return;
/* XXX: this code should not depend on lock_user */
- if (!(p = lock_user(VERIFY_READ, addr, len, 1)))
+ if (!(p = lock_user(VERIFY_READ, addr, l, 1)))
/* FIXME - should this return an error rather than just fail? */
return;
- memcpy(buf, p, len);
- unlock_user(p, addr, 0);
+ memcpy(buf, p, l);
+ unlock_user(p, addr, l);
}
len -= l;
buf += l;
reply other threads:[~2008-04-27 23:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JqGgj-0000Ab-Vy@cvs.savannah.gnu.org \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).