From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JqGgl-0001vs-Vk for qemu-devel@nongnu.org; Sun, 27 Apr 2008 19:53:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JqGgl-0001vW-6i for qemu-devel@nongnu.org; Sun, 27 Apr 2008 19:53:47 -0400 Received: from [199.232.76.173] (port=57379 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqGgl-0001vT-37 for qemu-devel@nongnu.org; Sun, 27 Apr 2008 19:53:47 -0400 Received: from savannah.gnu.org ([199.232.41.3] helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JqGgk-0002Na-TF for qemu-devel@nongnu.org; Sun, 27 Apr 2008 19:53:46 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1JqGgk-0000Af-7e for qemu-devel@nongnu.org; Sun, 27 Apr 2008 23:53:46 +0000 Received: from aurel32 by cvs.savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1JqGgj-0000Ab-Vy for qemu-devel@nongnu.org; Sun, 27 Apr 2008 23:53:46 +0000 MIME-Version: 1.0 Errors-To: aurel32 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Aurelien Jarno Message-Id: Date: Sun, 27 Apr 2008 23:53:45 +0000 Subject: [Qemu-devel] [4272] Fix a typo in cpu_physical_memory_rw() Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 4272 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4272 Author: aurel32 Date: 2008-04-27 23:53:45 +0000 (Sun, 27 Apr 2008) Log Message: ----------- Fix a typo in cpu_physical_memory_rw() (Samuel Thibault) Modified Paths: -------------- trunk/exec.c Modified: trunk/exec.c =================================================================== --- trunk/exec.c 2008-04-27 23:52:12 UTC (rev 4271) +++ trunk/exec.c 2008-04-27 23:53:45 UTC (rev 4272) @@ -2544,20 +2544,20 @@ if (!(flags & PAGE_WRITE)) return; /* XXX: this code should not depend on lock_user */ - if (!(p = lock_user(VERIFY_WRITE, addr, len, 0))) + if (!(p = lock_user(VERIFY_WRITE, addr, l, 0))) /* FIXME - should this return an error rather than just fail? */ return; - memcpy(p, buf, len); - unlock_user(p, addr, len); + memcpy(p, buf, l); + unlock_user(p, addr, l); } else { if (!(flags & PAGE_READ)) return; /* XXX: this code should not depend on lock_user */ - if (!(p = lock_user(VERIFY_READ, addr, len, 1))) + if (!(p = lock_user(VERIFY_READ, addr, l, 1))) /* FIXME - should this return an error rather than just fail? */ return; - memcpy(buf, p, len); - unlock_user(p, addr, 0); + memcpy(buf, p, l); + unlock_user(p, addr, l); } len -= l; buf += l;