From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4416] CRIS: helper_dummy no longer needed as barrier for qemu_ld/st.
Date: Sat, 10 May 2008 19:20:40 +0000 [thread overview]
Message-ID: <E1JuucZ-0001lE-Lg@cvs.savannah.gnu.org> (raw)
Revision: 4416
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4416
Author: edgar_igl
Date: 2008-05-10 19:20:33 +0000 (Sat, 10 May 2008)
Log Message:
-----------
CRIS: helper_dummy no longer needed as barrier for qemu_ld/st.
Modified Paths:
--------------
trunk/target-cris/translate.c
Modified: trunk/target-cris/translate.c
===================================================================
--- trunk/target-cris/translate.c 2008-05-10 18:43:02 UTC (rev 4415)
+++ trunk/target-cris/translate.c 2008-05-10 19:20:33 UTC (rev 4416)
@@ -1120,7 +1120,6 @@
{
int mem_index = cpu_mmu_index(dc->env);
- cris_evaluate_flags(dc);
if (size == 1) {
if (sign)
tcg_gen_qemu_ld8s(dst, addr, mem_index);
@@ -1276,8 +1275,6 @@
tcg_gen_movi_tl(cpu_T[1], imm);
dc->postinc = 0;
} else {
- /* FIXME: qemu_ld does not act as a barrier? */
- tcg_gen_helper_0_0(helper_dummy);
gen_load(dc, cpu_T[1], cpu_R[rs], memsize, 0);
if (s_ext)
t_gen_sext(cpu_T[1], cpu_T[1], memsize);
@@ -2340,8 +2337,6 @@
cris_evaluate_flags(dc);
t_gen_mov_TN_preg(cpu_T[1], dc->op2);
- /* FIXME: qemu_st does not act as a barrier? */
- tcg_gen_helper_0_0(helper_dummy);
gen_store(dc, cpu_R[dc->op1], cpu_T[1], memsize);
cris_cc_mask(dc, 0);
@@ -2358,9 +2353,6 @@
DIS(fprintf (logfile, "movem [$r%u%s, $r%u\n", dc->op1,
dc->postinc ? "+]" : "]", dc->op2));
- /* FIXME: qemu_ld does not act as a barrier? */
- tcg_gen_helper_0_0(helper_dummy);
-
/* fetch the address into T0 and T1. */
for (i = 0; i <= dc->op2; i++) {
tmp[i] = tcg_temp_new(TCG_TYPE_TL);
@@ -2390,9 +2382,6 @@
DIS(fprintf (logfile, "movem $r%u, [$r%u%s\n", dc->op2, dc->op1,
dc->postinc ? "+]" : "]"));
- /* FIXME: qemu_st does not act as a barrier? */
- tcg_gen_helper_0_0(helper_dummy);
-
for (i = 0; i <= dc->op2; i++) {
/* Displace addr. */
tcg_gen_addi_tl(cpu_T[0], cpu_R[dc->op1], i * 4);
@@ -2415,8 +2404,6 @@
memsize, dc->op2, dc->op1));
/* prepare store. */
- /* FIXME: qemu_st does not act as a barrier? */
- tcg_gen_helper_0_0(helper_dummy);
gen_store(dc, cpu_R[dc->op1], cpu_R[dc->op2], memsize);
if (dc->postinc)
reply other threads:[~2008-05-10 19:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JuucZ-0001lE-Lg@cvs.savannah.gnu.org \
--to=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).