From: Thiemo Seufer <ths@networkno.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4562] Un-break MIPS conditional moves, by Richard Sandiford.
Date: Sat, 24 May 2008 19:06:08 +0000 [thread overview]
Message-ID: <E1Jzz4C-0007ip-2a@cvs.savannah.gnu.org> (raw)
Revision: 4562
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4562
Author: ths
Date: 2008-05-24 19:06:07 +0000 (Sat, 24 May 2008)
Log Message:
-----------
Un-break MIPS conditional moves, by Richard Sandiford.
Modified Paths:
--------------
trunk/target-mips/translate.c
Modified: trunk/target-mips/translate.c
===================================================================
--- trunk/target-mips/translate.c 2008-05-24 18:09:50 UTC (rev 4561)
+++ trunk/target-mips/translate.c 2008-05-24 19:06:07 UTC (rev 4562)
@@ -5547,10 +5547,6 @@
static void gen_movci (DisasContext *ctx, int rd, int rs, int cc, int tf)
{
- TCGv r_ptr = tcg_temp_new(TCG_TYPE_PTR);
- TCGv r_tmp = new_tmp();
- TCGv t0 = tcg_temp_new(TCG_TYPE_TL);
- TCGv t1 = tcg_temp_new(TCG_TYPE_TL);
int l1 = gen_new_label();
uint32_t ccbit;
TCGCond cond;
@@ -5560,20 +5556,26 @@
else
ccbit = 1 << 23;
if (tf)
+ cond = TCG_COND_EQ;
+ else
cond = TCG_COND_NE;
- else
- cond = TCG_COND_EQ;
- gen_load_gpr(t0, rd);
- gen_load_gpr(t1, rs);
- tcg_gen_ld_ptr(r_ptr, cpu_env, offsetof(CPUState, fpu));
- tcg_gen_ld_i32(r_tmp, r_ptr, offsetof(CPUMIPSFPUContext, fcr31));
- tcg_gen_andi_i32(r_tmp, r_tmp, ccbit);
- tcg_gen_brcondi_i32(cond, r_tmp, 0, l1);
- tcg_gen_mov_tl(t0, t1);
+ gen_load_gpr(cpu_T[0], rd);
+ gen_load_gpr(cpu_T[1], rs);
+ {
+ TCGv r_ptr = tcg_temp_new(TCG_TYPE_PTR);
+ TCGv r_tmp = new_tmp();
+
+ tcg_gen_ld_ptr(r_ptr, cpu_env, offsetof(CPUState, fpu));
+ tcg_gen_ld_i32(r_tmp, r_ptr, offsetof(CPUMIPSFPUContext, fcr31));
+ tcg_gen_andi_i32(r_tmp, r_tmp, ccbit);
+ tcg_gen_brcondi_i32(cond, r_tmp, 0, l1);
+ dead_tmp(r_tmp);
+ }
+ tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
+
gen_set_label(l1);
- dead_tmp(r_tmp);
- gen_store_gpr(t0, rd);
+ gen_store_gpr(cpu_T[0], rd);
}
#define GEN_MOVCF(fmt) \
reply other threads:[~2008-05-24 19:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Jzz4C-0007ip-2a@cvs.savannah.gnu.org \
--to=ths@networkno.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).