qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [4566] Fix a deadly typo, correct comments.
@ 2008-05-24 22:56 Andrzej Zaborowski
  0 siblings, 0 replies; only message in thread
From: Andrzej Zaborowski @ 2008-05-24 22:56 UTC (permalink / raw)
  To: qemu-devel

Revision: 4566
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4566
Author:   balrog
Date:     2008-05-24 22:56:51 +0000 (Sat, 24 May 2008)

Log Message:
-----------
Fix a deadly typo, correct comments.

Modified Paths:
--------------
    trunk/tcg/arm/tcg-target.c

Modified: trunk/tcg/arm/tcg-target.c
===================================================================
--- trunk/tcg/arm/tcg-target.c	2008-05-24 22:29:16 UTC (rev 4565)
+++ trunk/tcg/arm/tcg-target.c	2008-05-24 22:56:51 UTC (rev 4566)
@@ -78,7 +78,7 @@
         tcg_abort();
 
     case R_ARM_PC24:
-        *(uint32_t *) code_ptr |= (*(uint32_t *) code_ptr & 0xff000000) |
+        *(uint32_t *) code_ptr = ((*(uint32_t *) code_ptr) & 0xff000000) |
                 (((value - ((tcg_target_long) code_ptr + 8)) >> 2) & 0xffffff);
         break;
     }
@@ -109,7 +109,7 @@
         break;
 
 #ifdef CONFIG_SOFTMMU
-    /* qemu_ld/st inputs (unless 'd', 'D' or 'X') */
+    /* qemu_ld/st inputs (unless 'X' or 'D') */
     case 'x':
         ct->ct |= TCG_CT_REG;
         tcg_regset_set32(ct->u.regs, 0, (1 << TCG_TARGET_NB_REGS) - 1);
@@ -995,7 +995,8 @@
         tcg_out_ld32_12(s, COND_AL, data_reg, addr_reg, 0);
         break;
     case 3:
-        /* TODO: use block load */
+        /* TODO: use block load -
+         * check that data_reg2 > data_reg or the other way */
         tcg_out_ld32_12(s, COND_AL, data_reg, addr_reg, 0);
         tcg_out_ld32_12(s, COND_AL, data_reg2, addr_reg, 4);
         break;
@@ -1200,7 +1201,8 @@
         tcg_out_st32_12(s, COND_AL, data_reg, addr_reg, 0);
         break;
     case 3:
-        /* TODO: use block store */
+        /* TODO: use block store -
+         * check that data_reg2 > data_reg or the other way */
         tcg_out_st32_12(s, COND_AL, data_reg, addr_reg, 0);
         tcg_out_st32_12(s, COND_AL, data_reg2, addr_reg, 4);
         break;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-24 22:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-24 22:56 [Qemu-devel] [4566] Fix a deadly typo, correct comments Andrzej Zaborowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).