qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4611] keep static code gen buffer for user mode - mark user mode reserved pages after all big allocations
Date: Thu, 29 May 2008 09:35:58 +0000	[thread overview]
Message-ID: <E1K1eYA-0001bP-4t@cvs.savannah.gnu.org> (raw)

Revision: 4611
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4611
Author:   bellard
Date:     2008-05-29 09:35:57 +0000 (Thu, 29 May 2008)

Log Message:
-----------
keep static code gen buffer for user mode - mark user mode reserved pages after all big allocations

Modified Paths:
--------------
    trunk/exec.c

Modified: trunk/exec.c
===================================================================
--- trunk/exec.c	2008-05-29 00:20:44 UTC (rev 4610)
+++ trunk/exec.c	2008-05-29 09:35:57 UTC (rev 4611)
@@ -187,14 +187,15 @@
 #else
 static void map_exec(void *addr, long size)
 {
-    unsigned long start, end;
+    unsigned long start, end, page_size;
     
+    page_size = getpagesize();
     start = (unsigned long)addr;
-    start &= ~(qemu_real_host_page_size - 1);
+    start &= ~(page_size - 1);
     
     end = (unsigned long)addr + size;
-    end += qemu_real_host_page_size - 1;
-    end &= ~(qemu_real_host_page_size - 1);
+    end += page_size - 1;
+    end &= ~(page_size - 1);
     
     mprotect((void *)start, end - start,
              PROT_READ | PROT_WRITE | PROT_EXEC);
@@ -326,12 +327,34 @@
                                     target_ulong vaddr);
 #endif
 
+#define DEFAULT_CODE_GEN_BUFFER_SIZE (32 * 1024 * 1024)
+
+#if defined(CONFIG_USER_ONLY)
+/* Currently it is not recommanded to allocate big chunks of data in
+   user mode. It will change when a dedicated libc will be used */
+#define USE_STATIC_CODE_GEN_BUFFER
+#endif
+
+#ifdef USE_STATIC_CODE_GEN_BUFFER
+static uint8_t static_code_gen_buffer[DEFAULT_CODE_GEN_BUFFER_SIZE];
+#endif
+
 void code_gen_alloc(unsigned long tb_size)
 {
+#ifdef USE_STATIC_CODE_GEN_BUFFER
+    code_gen_buffer = static_code_gen_buffer;
+    code_gen_buffer_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
+    map_exec(code_gen_buffer, code_gen_buffer_size);
+#else
     code_gen_buffer_size = tb_size;
     if (code_gen_buffer_size == 0) {
+#if defined(CONFIG_USER_ONLY)
+        /* in user mode, phys_ram_size is not meaningful */
+        code_gen_buffer_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
+#else
         /* XXX: needs ajustments */
         code_gen_buffer_size = (int)(phys_ram_size / 4);
+#endif
     }
     if (code_gen_buffer_size < MIN_CODE_GEN_BUFFER_SIZE)
         code_gen_buffer_size = MIN_CODE_GEN_BUFFER_SIZE;
@@ -363,6 +386,7 @@
     }
     map_exec(code_gen_buffer, code_gen_buffer_size);
 #endif
+#endif /* !USE_STATIC_CODE_GEN_BUFFER */
     map_exec(code_gen_prologue, sizeof(code_gen_prologue));
     code_gen_buffer_max_size = code_gen_buffer_size - 
         code_gen_max_block_size();
@@ -375,10 +399,10 @@
    size. */
 void cpu_exec_init_all(unsigned long tb_size)
 {
-    page_init();
     cpu_gen_init();
     code_gen_alloc(tb_size);
     code_gen_ptr = code_gen_buffer;
+    page_init();
     io_mem_init();
 }
 

                 reply	other threads:[~2008-05-29  9:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1K1eYA-0001bP-4t@cvs.savannah.gnu.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).