From: Paul Brook <paul@nowt.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4627] Handle NULL argp/envp in execve syscall.
Date: Fri, 30 May 2008 18:24:00 +0000 [thread overview]
Message-ID: <E1K29Gi-0003a9-DV@cvs.savannah.gnu.org> (raw)
Revision: 4627
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4627
Author: pbrook
Date: 2008-05-30 18:24:00 +0000 (Fri, 30 May 2008)
Log Message:
-----------
Handle NULL argp/envp in execve syscall.
Modified Paths:
--------------
trunk/linux-user/syscall.c
Modified: trunk/linux-user/syscall.c
===================================================================
--- trunk/linux-user/syscall.c 2008-05-30 18:20:05 UTC (rev 4626)
+++ trunk/linux-user/syscall.c 2008-05-30 18:24:00 UTC (rev 4627)
@@ -3248,7 +3248,7 @@
argc = 0;
guest_argp = arg2;
- for (gp = guest_argp; ; gp += sizeof(abi_ulong)) {
+ for (gp = guest_argp; gp; gp += sizeof(abi_ulong)) {
if (get_user_ual(addr, gp))
goto efault;
if (!addr)
@@ -3257,7 +3257,7 @@
}
envc = 0;
guest_envp = arg3;
- for (gp = guest_envp; ; gp += sizeof(abi_ulong)) {
+ for (gp = guest_envp; gp; gp += sizeof(abi_ulong)) {
if (get_user_ual(addr, gp))
goto efault;
if (!addr)
@@ -3268,7 +3268,7 @@
argp = alloca((argc + 1) * sizeof(void *));
envp = alloca((envc + 1) * sizeof(void *));
- for (gp = guest_argp, q = argp; ;
+ for (gp = guest_argp, q = argp; gp;
gp += sizeof(abi_ulong), q++) {
if (get_user_ual(addr, gp))
goto execve_efault;
@@ -3279,7 +3279,7 @@
}
*q = NULL;
- for (gp = guest_envp, q = envp; ;
+ for (gp = guest_envp, q = envp; gp;
gp += sizeof(abi_ulong), q++) {
if (get_user_ual(addr, gp))
goto execve_efault;
reply other threads:[~2008-05-30 18:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1K29Gi-0003a9-DV@cvs.savannah.gnu.org \
--to=paul@nowt.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).