From: Paul Brook <paul@nowt.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [4712] Use qemu_mallocz to allocate new thread state.
Date: Mon, 09 Jun 2008 14:02:51 +0000 [thread overview]
Message-ID: <E1K5hxT-0005rf-3S@cvs.savannah.gnu.org> (raw)
Revision: 4712
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4712
Author: pbrook
Date: 2008-06-09 14:02:50 +0000 (Mon, 09 Jun 2008)
Log Message:
-----------
Use qemu_mallocz to allocate new thread state. Remove redundant memset.
Modified Paths:
--------------
trunk/linux-user/main.c
trunk/linux-user/syscall.c
Modified: trunk/linux-user/main.c
===================================================================
--- trunk/linux-user/main.c 2008-06-09 13:57:23 UTC (rev 4711)
+++ trunk/linux-user/main.c 2008-06-09 14:02:50 UTC (rev 4712)
@@ -2183,11 +2183,11 @@
THREAD CPUState *thread_env;
+/* Assumes contents are already zeroed. */
void init_task_state(TaskState *ts)
{
int i;
- memset(ts, 0, sizeof(TaskState));
ts->used = 1;
ts->first_free = ts->sigqueue_table;
for (i = 0; i < MAX_SIGQUEUE_SIZE - 1; i++) {
Modified: trunk/linux-user/syscall.c
===================================================================
--- trunk/linux-user/syscall.c 2008-06-09 13:57:23 UTC (rev 4711)
+++ trunk/linux-user/syscall.c 2008-06-09 14:02:50 UTC (rev 4712)
@@ -2787,7 +2787,7 @@
new_thread_info info;
pthread_attr_t attr;
#endif
- ts = malloc(sizeof(TaskState) + NEW_STACK_SIZE);
+ ts = qemu_mallocz(sizeof(TaskState) + NEW_STACK_SIZE);
init_task_state(ts);
new_stack = ts->stack;
/* we create a new CPU instance. */
reply other threads:[~2008-06-09 14:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1K5hxT-0005rf-3S@cvs.savannah.gnu.org \
--to=paul@nowt.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).